Zip archive fails to parse on portable package update

[TheJanzap]

Brief description of your issue

I'm trying to update the Martchus.syncthingtray package, but after the selection of the new "installer", I get "Failed to parse the package from". This is a package that's marked as a portable installer, and the zip file that gets downloaded contains the new exe

Steps to reproduce

1. Run wingetcreate update Martchus.syncthingtray -i -v 1.4.8
2. Enter https://github.com/Martchus/syncthingtray/releases/download/v1.4.8/syncthingtray-1.4.8-x86_64-w64-mingw32.exe.zip as new URL
3. Select syncthingtray-1.4.8-x86_64-w64-mingw32.exe as the new installer

Expected behavior

Package parses correctly and lets me continue with updating the package

Actual behavior

Failed to parse the package from [https://github.com/Martchus/syncthingtray/releases/download/v1.4.8/syncthingtray-1.4.8-x86_64-w64-mingw32.exe.zip]

Log file: WingetCreateLog-2023-11-20-17-14.342.txt

Environment

Windows-Paket-Manager Manifest Creator v1.5.7.0

Windows-Paket-Manager (Vorschau) v1.7.2782-preview
Copyright (c) Microsoft Corporation. Alle Rechte vorbehalten.

Windows: Windows.Desktop v10.0.22631.2715
Systemarchitektur: X64
Paket: Microsoft.DesktopAppInstaller v1.22.2782.0

[mdanish-kh]

I cannot reproduce the issue since the file doesn't even get downloaded on my machine (it's getting flagged as virus which is preventing it from being downloaded).

[BrandonWanHuanSheng]

I cannot reproduce the issue since the file doesn't even get downloaded on my machine (it's getting flagged as virus which is preventing it from being downloaded).

Seem like the app contains virus which unable to download.

https://www.virustotal.com/gui/file/8aa8b2613db4d06a19bbf89bf785de3859e05606441b94b3d7a3586f6aba16c0/detection

[TheJanzap]

I cannot reproduce the issue since the file doesn't even get downloaded on my machine (it's getting flagged as virus which is preventing it from being downloaded).

The download works fine on my end.

Seem like the app contains virus which unable to download.

It's a known problem that the program is being flagged as a false positive https://github.com/Martchus/syncthingtray#packages-and-binaries https://github.com/Martchus/syncthingtray/issues/207

[BrandonWanHuanSheng]

[TheJanzap]

The dev just released a new version that doesn't get flagged by Windows Defender, but the updating of the package still fails. https://github.com/Martchus/syncthingtray/releases/tag/v1.4.10 WingetCreateLog-2023-12-11-13-35.476.txt

[mdanish-kh]

@TheJanzap I couldn't reproduce the same at my end, the manifest creation works fine. This is odd since we're both on version 1.5.7.0....

https://github.com/microsoft/winget-create/assets/88161975/352c0ea1-1569-4e09-b9f0-36a2fa8e11d0

[TheJanzap]

@mdanish-kh Tried it on a different machine, same issue

Windows-Paket-Manager Manifest Creator v1.5.7.0

Windows-Paket-Manager (Vorschau) v1.7.3172-preview
Windows: Windows.Desktop v10.0.19045.3693
Systemarchitektur: X64
Paket: Microsoft.DesktopAppInstaller v1.22.3172.0

[TheJanzap]

Tried this again with wingetcreate v1.6.1.0 and Syncthingtray v1.4.13, but I still have the same problem. A reinstall of wingetcreate also does nothing.

[The-Running-Dev]

I have a similar/same issue. Here is how reproduce:

wingetcreate update CologneCodeCompany.XYplorerPortable --token MYSECRETTOKEN --version 26.20.0100

Errors out with

Retrieving latest manifest for CologneCodeCompany.XYplorerPortable
Downloading and parsing: https://www.xyplorer.com/download/xyplorer_full_noinstall.zip...
System.Xml.XmlException: 'asmv3' is an undeclared prefix. Line 54, position 2.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String arg, Int32 lineNo, Int32 linePos)
   at System.Xml.XmlTextReaderImpl.LookupNamespace(NodeData node)
   at System.Xml.XmlTextReaderImpl.ElementNamespaceLookup()
   at System.Xml.XmlTextReaderImpl.ParseElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XmlLoader.LoadNode(Boolean skipOverWhitespace)
   at System.Xml.XmlLoader.LoadDocSequence(XmlDocument parentDoc)
   at System.Xml.XmlLoader.Load(XmlDocument doc, XmlReader reader, Boolean preserveWhitespace)
   at System.Xml.XmlDocument.Load(XmlReader reader)
   at System.Xml.XmlDocument.LoadXml(String xml)
   at Vestris.ResourceLib.ManifestResource.get_Manifest()
   at Microsoft.WingetCreateCore.PackageParser.ParseExeInstallerType(String path, Installer baseInstaller, List`1 newInstallers)
   at Microsoft.WingetCreateCore.PackageParser.ParsePackageAndGenerateInstallerNodes(InstallerMetadata installerMetadata, Manifests manifests)
   at Microsoft.WingetCreateCore.PackageParser.UpdateInstallerNodesAsync(List`1 installerMetadataList, InstallerManifest installerManifest)
   at Microsoft.WingetCreateCLI.Commands.UpdateCommand.UpdateManifestsAutonomously(Manifests manifests)
   at Microsoft.WingetCreateCLI.Commands.UpdateCommand.ExecuteManifestUpdate(List`1 latestManifestContent, CommandExecutedEvent commandEvent)
   at Microsoft.WingetCreateCLI.Commands.UpdateCommand.Execute()
   at Microsoft.WingetCreateCLI.Program.Main(String[] args)