vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Enhance Branch Creation UX and Refactor Issue Branch Management

Open amrshadid opened this issue 1 year ago • 2 comments

This PR introduces significant improvements to the branch creation and management process, focusing on enhancing the user experience and refactoring the existing code for better maintainability and performance. Key changes include:

  • Branch Selection UI Overhaul:

    • Introduced a QuickPick interface for selecting branches, allowing users to choose from existing local/remote branches or create a new one.
    • Visually highlighted branches related to the issue (e.g., branches containing the issue number).
    • Provided a custom branch name option directly in the selection UI for flexible branch creation.

Some Related Issues:

  • #2243: Detect and use already-linked PR branches when starting work on an issue.
  • #4120: Detect branch names referencing an issue and automatically start working on them.
  • #4509: Improve transparency when creating and checking out branches for issues.

These issues are addressed by improving the branch selection experience, handling remote branches more seamlessly, and enhancing error feedback.

Testing and Verification:

  • Manual Testing:

    • [x] Verified that the QuickPick interface correctly displays existing branches and suggested branch names.
    • [x] Tested creation and checkout of local and remote branches.
    • [x] Confirmed proper upstream tracking for remote branches.
    • [x] Ensured that validation errors (e.g., invalid branch names) display appropriate messages.

amrshadid avatar Oct 13 '24 01:10 amrshadid

@microsoft-github-policy-service agree

amrshadid avatar Oct 13 '24 01:10 amrshadid

@alexr00 Thanks for the feedback! I’ve addressed the specific comments and focused on ensuring the necessary changes related to the feature.

amrshadid avatar Oct 19 '24 13:10 amrshadid