vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Unclear behavior when having two changes, one inside a comment and one outside

Open dbaeumer opened this issue 1 year ago • 2 comments

Testing #6160

I did two change, one inside a comment and one outside and then ran the action from the SCM viewlet. Here is what happend:

  • got the dialog.
  • the one inside the comment got converted but the diff didn't revert. I would have expected to see that happening since the suggestion got created.
  • the other diff stayed, which is IMO correct.

dbaeumer avatar Aug 27 '24 09:08 dbaeumer

I only show the option to revert the change if all the conversions succeeded. I'll add an option to revert even if not everything succeeded.

alexr00 avatar Aug 27 '24 17:08 alexr00

Actually, I can only revert entire files, not just select changes. I think the current behavior is less confusing than only reverting the files for which ever suggestion conversion succeeded.

alexr00 avatar Aug 28 '24 14:08 alexr00