vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Ensure only directories are added to FilesCategoryNode's internal directories array

Open joshuaobrien opened this issue 2 years ago • 1 comments

I noticed that in certain circumstances GitFileChangeNodes on the root were getting disposed of and never completely reinitialised. I think this was because they were sometimes being treated as though they were DirectoryTreeNodes

image

joshuaobrien avatar Dec 10 '23 05:12 joshuaobrien

This change breaks the file tree for PRs where the file that has been changed is at the root:

image

How it should look:

image

Do you have an example of the issue you were seeing?

alexr00 avatar Dec 12 '23 10:12 alexr00

Ah, it's been a while. I'll close this for now so it's not clogging up the project's open PRs list. Hopefully I can get back to it soon

joshuaobrien avatar Apr 04 '24 10:04 joshuaobrien