vscode-pull-request-github icon indicating copy to clipboard operation
vscode-pull-request-github copied to clipboard

Mark as viewed close file option

Open brucejo75 opened this issue 3 years ago • 0 comments

Hi All, Thanks for this fantastic extension!

I am in the process of reviewing a change to over 200 files. (yes, I know...)

I run VSCode with "workbench.editor.enablePreview": false (yes, I know.. I am a tab binger)

While reviewing the code I would like the file to close after each review is complete. Which does not happen if "workbench.editor.enablePreview": false.

Pardon me if this feature exists, I could not find it.

What I think would be valid options:

  1. Close the window when I select Mark as Viewed &/or close the file under review when I select another file for review.
  2. New options setting githubpullrequest.editor.enablePreview (Default: true)
  3. Put the editor into enablePreview mode during any github pull request review with no user option to change.

For a user like me #1 seems optimal. As I may have other windows open other than the review window.

But I think any of the solutions would be a big improvement for my scenario.

Workaround

Just review a batch of files then close all in the window. (but this gets rid of some other windows I have open, no big deal really)

Thanks!

brucejo75 avatar May 03 '22 19:05 brucejo75