vscode-docker icon indicating copy to clipboard operation
vscode-docker copied to clipboard
verified publisher icon microsoft

Move "build in ACR" command to ACA extension

Open bwateratmsft opened this issue 2 years ago • 4 comments

The Azure Container Apps extension is soon adding a command to build images in ACR. Using this would allow us to remove several Azure packages as dependencies, improving load time and reducing bundle size.

TODO: do we want to remove the command entirely, or leave in a soft entry point like we currently have with "Deploy to ACA"?

bwateratmsft avatar Mar 20 '23 14:03 bwateratmsft

Will this require having an ACA dependency to simply deploy to ACR?

dbreshears avatar Mar 22 '23 18:03 dbreshears

Will this require having an ACA dependency to simply deploy to ACR?

No, the only thing I'd like to move is the "Run as task in Azure" / "Build image in Azure" feature. Local build and push, along with the other ACR features (repo browser essentially) should definitely stay in the Docker extension.

bwateratmsft avatar Mar 23 '23 14:03 bwateratmsft

Let's seperate this into an NPM package that ACA and other extensions can leverage

dbreshears avatar Apr 19 '23 18:04 dbreshears

Moving to future as ACA still requires the Docker extension for authenticating and getting subscription/registry information.

dbreshears avatar Jun 14 '23 18:06 dbreshears