vscode-docker icon indicating copy to clipboard operation
vscode-docker copied to clipboard

Support creating a new SSH or HTTP(S) context from the Contexts panel

Open BigMorty opened this issue 5 years ago • 5 comments

Similar to the + sign in the Networks panel we should support creating a SSH context. Once we support ACI and SSH context creation the + sign icon should prompt user for type of context. For SSH we should prompt for endpoint.

BigMorty avatar Jun 29 '20 23:06 BigMorty

@BigMorty what about

  • tls, tlscacert, tlscert, tlskey, and tlsverify options
  • Certificate path (DOCKER_CERT_PATH equivalent)

See https://docs.docker.com/engine/context/working-with-contexts/#the-anatomy-of-a-context and https://docs.docker.com/engine/reference/commandline/cli/ for reference

karolz-ms avatar Jun 29 '20 23:06 karolz-ms

We should talk with Docker folks and see what is most common. When I created a context to use against the Azure VM you shared with me there were not many params I had to specify. I am not suggesting we support every possible combination.

BigMorty avatar Jun 29 '20 23:06 BigMorty

Also, if one is not very familiar with how SSH works and how to set up SSH agent for key management, the SSH context created by VS Code will not work.

karolz-ms avatar Jun 29 '20 23:06 karolz-ms

Good point. Let's think about this and discuss more. This is lower priority than the create ACI context anyways.

BigMorty avatar Jun 29 '20 23:06 BigMorty

We're talking about 0.2% of the population using SSH, I don't see how that justifies much effort. Additionally, creating the context is just setting them up for failure unless they already have an SSH auth agent running, and it is not possible for us to start it for them.

bwateratmsft avatar Jun 30 '20 12:06 bwateratmsft