vscode-docker icon indicating copy to clipboard operation
vscode-docker copied to clipboard

Add "unpause" option to paused containers

Open ejizba opened this issue 6 years ago • 4 comments

Repro steps:

  1. Pause a container
  2. Right click on the container, select start

Expected: Start works or I can "unpause"

Actual: Start doesn't work and there is no unpause

Action: vscode-docker.containers.start Error type: 409 Error Message: (HTTP code 409) unexpected - cannot start a paused container, try unpause instead

Version: 0.7.1-alpha OS: darwin Product: Visual Studio Code Product Version: 1.36.1 Language: en

Call Stack
docker-modem/modem.js:257:17
getCause docker-modem/modem.js:287:7
Modem.buildPayload docker-modem/modem.js:256:5
IncomingMessage.<anonymous> docker-modem/modem.js:232:14
IncomingMessage.emit events.js:187:15
endReadableNT _stream_readable.js:1092:12
process._tickCallback next_tick.js:63:19

ejizba avatar Aug 08 '19 18:08 ejizba

Should we add unpause or just have start unpause it if it's in a paused state? Seems like kind of a silly context menu item to add.

nturinski avatar Aug 08 '19 20:08 nturinski

The terminology is coming directly from Docker, so I feel like we should be consistent. Also - in Docker we only display start/stop/restart/etc. for applicable items so it won't add any clutter. In other words "unpause" will only show for paused containers

ejizba avatar Aug 08 '19 20:08 ejizba

Oh right, your crazy dynamic context values

nturinski avatar Aug 08 '19 22:08 nturinski

Lol nah the crazy stuff is for registries. This is a pretty simple one that just adds "state" at the beginning here with an example reference in package.json here

It would probably be pretty easy to replicate for app service or functions if we want to hide start/stop/etc.

ejizba avatar Aug 08 '19 23:08 ejizba