vscode-cpptools icon indicating copy to clipboard operation
vscode-cpptools copied to clipboard

Add detection of C++ standard argument specified in tasks.json

Open jackielwu opened this issue 2 years ago • 6 comments

Add fix #11828

jackielwu avatar Jan 03 '24 07:01 jackielwu

@microsoft-github-policy-service agree

jackielwu avatar Jan 03 '24 07:01 jackielwu

@jackielwu I don't think this change is necessary. When -std=gnu++14 -std=c++20 is used the 2nd argument overrides the 1st argument, so the existence of the 1st argument should not matter.

sean-mcmanus avatar Jan 03 '24 22:01 sean-mcmanus

@sean-mcmanus Does this behavior apply to both llvm clang and Apple clang? What if the user specifies an earlier standard (e.g. -std=gnu++14 -std=c++11)?

jackielwu avatar Jan 04 '24 02:01 jackielwu

@sean-mcmanus Does this behavior apply to both llvm clang and Apple clang? What if the user specifies an earlier standard (e.g. -std=gnu++14 -std=c++11)?

Yes, that applies to LLVM and Apple clang and the last/right-most "-std" gets used regardless of if it's earlier or newer.

sean-mcmanus avatar Jan 08 '24 19:01 sean-mcmanus

I don't believe this is needed. I'm not able to repro an issue from https://github.com/microsoft/vscode-cpptools/issues/11828 , and suspect that issue is user-error.

Colengms avatar Jan 30 '24 23:01 Colengms

Thank you for the update! If there's anything else I can assist with, please let me know.

Best, [Your Name] https://gpt.space/gmail?source=watermark On Fri, Feb 09, 2024 11:16 PM, @.*** wrote:

@.**** approved this pull request.

— Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode-cpptools/pull/11829#pullrequestreview-1871643881, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBJ7LML6H5DUSY2HJZBGLA3YSWSE5AVCNFSM6AAAAABBLAZBDSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZRGY2DGOBYGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Wxnd3rlabs1 avatar Feb 09 '24 15:02 Wxnd3rlabs1