vscode-cmake-tools icon indicating copy to clipboard operation
vscode-cmake-tools copied to clipboard

FOLDER grouping in default build target dropdown

Open itzandroidtab opened this issue 1 year ago • 5 comments

This changes visible behavior

The following changes are proposed:

  • Grouping default build targets dropdown based on CMake FOLDER property

The purpose of this change

When a project has a lot of targets it becomes a hassle to find the right default build target. In the project outline the targets are grouped. This PR also groups the default build target dropdown. Discussion #3949. When clicking on the folder it will show the corresponding targets.

Previous

image

New

image After selecting the folder: image

itzandroidtab avatar Aug 01 '24 23:08 itzandroidtab

@gcampbell-msft @qarni What would I need to do to have this PR merged?

itzandroidtab avatar Sep 04 '24 12:09 itzandroidtab

@itzandroidtab Our apologies for the delay, we've been in the midst of the 1.19 official version release, so we've not been able to review community PR's. We hope to get to this soon, thanks and we appreciate your patience.

gcampbell-msft avatar Sep 04 '24 13:09 gcampbell-msft

@gcampbell-msft What would you call this option? And should this option also apply to the side view?

itzandroidtab avatar Oct 12 '24 22:10 itzandroidtab

@gcampbell-msft What would you call this option? And should this option also apply to the side view?

I don't believe this option should apply to the side view, the FOLDER grouping should be used there always. The setting should only be used in the build target dropdown.

For the name, it could be something like: cmake.useFolderPropertyInBuildTargetDropdown

gcampbell-msft avatar Oct 14 '24 11:10 gcampbell-msft

Thank you. I will work on this

itzandroidtab avatar Oct 14 '24 11:10 itzandroidtab

@itzandroidtab Changing this to a draft PR until further changes are made. Please let us know if you have any questions but we will leave it in a draft state for a while, and then if no updates are made we may need to close it in order to keep our PRs clean. We're interested in considering this change once the settings option is added! Thanks!

gcampbell-msft avatar Dec 09 '24 19:12 gcampbell-msft

@gcampbell-msft I have added the feature to the CHANGELOG.md and added the option to enable/disable this feature. By default it is turned on

image

itzandroidtab avatar Apr 21 '25 22:04 itzandroidtab

@gcampbell-msft I have changed the default to false

itzandroidtab avatar Apr 25 '25 16:04 itzandroidtab