vscode-azurefunctions icon indicating copy to clipboard operation
vscode-azurefunctions copied to clipboard

add sqlTrigger to verifiedtemplates

Open MaddyDev opened this issue 2 years ago • 4 comments

adding Sql trigger to verified templates

MaddyDev avatar Apr 22 '24 18:04 MaddyDev

Hi @MaddyDev

Part of our process to adding templates to the verified list is to create a test for creating that specific template trigger. We do this to ensure that the template is created as we expected and we can catch anytime the input/parameter change from what we expected.

Please add a test creating the sqlTrigger. Feel free to reach out and I can give you examples of how to do that.

nturinski avatar Apr 25 '24 17:04 nturinski

Hi @MaddyDev

Part of our process to adding templates to the verified list is to create a test for creating that specific template trigger. We do this to ensure that the template is created as we expected and we can catch anytime the input/parameter change from what we expected.

Please add a test creating the sqlTrigger. Feel free to reach out and I can give you examples of how to do that.

Thanks @nturinski for calling out, I have added them and haven't pushed them. Quick question, I see that some of the extensions also edited templateCount.test.ts (ref https://github.com/microsoft/vscode-azurefunctions/pull/3916/files). Can you explain if this is needed for us?

MaddyDev avatar Apr 25 '24 18:04 MaddyDev

@MaddyDev So it seems like a lot of the tests are failing now. Is the SqlTrigger actually available in all of these runtimes? Like Python, all .NET runtimes, etc.? It doesn't appear to be showing up.

nturinski avatar Apr 30 '24 21:04 nturinski

@MaddyDev Just want to see if there's any update on this

nturinski avatar May 09 '24 17:05 nturinski

Closing in favor of https://github.com/microsoft/vscode-azurefunctions/pull/4358

nturinski avatar Jan 14 '25 22:01 nturinski