vcpkg icon indicating copy to clipboard operation
vcpkg copied to clipboard

[llvm] Update to 18.1.4

Open yurybura opened this issue 2 years ago • 2 comments

Fixes #37189

  • [x] Changes comply with the maintainer guide.
  • [x] SHA512s are updated for each updated download.
  • [x] The "supports" clause reflects platforms that may be fixed by this new version.
  • [x] Any fixed CI baseline entries are removed from that file.
  • [x] Any patches that are no longer applied are deleted from the port's directory.
  • [x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • [x] Only one version is added to each modified port's versions file.

yurybura avatar Mar 21 '24 15:03 yurybura

hmm for some reason I would like to see patches for https://github.com/llvm/llvm-project/pull/79694 and https://github.com/llvm/llvm-project/pull/75711 applied so there is at least one place to get a useable clang-cl ;)

Neumann-A avatar Mar 22 '24 16:03 Neumann-A

hmm for some reason I would like to see patches for llvm/llvm-project#79694 and llvm/llvm-project#75711 applied so there is at least one place to get a useable clang-cl ;)

Patches have been added.

yurybura avatar Apr 22 '24 20:04 yurybura

the gstreamer issues seems be missing an include folder. The glib pc files have the correct include paths and the meson logs also show them. So the build is probably just missing a dependency.

Why does this require meson 1.4? the meson.build of meson just has 1.1.0 as a requirement

Neumann-A avatar May 15 '24 14:05 Neumann-A

Why does this require meson 1.4? the meson.build of meson just has 1.1.0 as a requirement

LLVM 18 issues: https://github.com/mesonbuild/meson/commit/dec93ce9a52b234ed4cb25646eaf13c503ba739a https://github.com/mesonbuild/meson/commit/67afddbf431140c1ee064bf79a2fa5a95575488e

yurybura avatar May 15 '24 14:05 yurybura

the gstreamer issues seems be missing an include folder. The glib pc files have the correct include paths and the meson logs also show them. So the build is probably just missing a dependency.

Nothing has changed in gstreamer. Only the meson was updated.

Glib dependency: https://github.com/microsoft/vcpkg/blob/bd2b54836beed96e1efbe9aaf8ee800f5448856d/ports/gstreamer/vcpkg.json#L10

yurybura avatar May 15 '24 14:05 yurybura

the gstreamer issues seems be missing an include folder. The glib pc files have the correct include paths and the meson logs also show them. So the build is probably just missing a dependency.

Nothing has changed in gstreamer. Only the meson was updated.

Doesn't meson generate the pc files for glib? Do the new files have the correct include path?

dg0yt avatar May 16 '24 04:05 dg0yt

According to the meson dependency logs from ci the pc file seems to be fine.

Neumann-A avatar May 16 '24 05:05 Neumann-A

as a workaround: Instead of updating meson, patching would also be possible. This at least should take care of the gstreamer regressions.

Neumann-A avatar May 17 '24 07:05 Neumann-A

as a workaround: Instead of updating meson, patching would also be possible. This at least should take care of the gstreamer regressions.

Actually I wanted to update LLVM, but blocked by mesa and meson. I don't think that I have enough power to patch all these projects.

yurybura avatar May 17 '24 09:05 yurybura

@yurybura You already have the upstream patch you just need to supply it to the meson in vcpkg without updating it to 1.4 (at least I assume it is that easy). One of the mesa regressions here says that feature egl is not supported on macos so just deactivate that feature?

Neumann-A avatar May 17 '24 09:05 Neumann-A

@yurybura You already have the upstream patch you just need to supply it to the meson in vcpkg without updating it to 1.4 (at least I assume it is that easy). One of the mesa regressions here says that feature egl is not supported on macos so just deactivate that feature?

There are at least 2 incomplete PRs with only patches (without version update): #36081 #38658 I don't think it makes sense to patch older versions.

yurybura avatar May 17 '24 09:05 yurybura

I can put the tiny llvm 18 changes into a tiny meson update factored out of https://github.com/microsoft/vcpkg/pull/38658.

dg0yt avatar May 17 '24 18:05 dg0yt

#38965 for kf5kio regression.

dg0yt avatar May 27 '24 17:05 dg0yt

@JonLiu1993 Could you please start review?

yurybura avatar Jun 04 '24 15:06 yurybura