[curl] Add Unicode support

[rozdaybeda]

Describe the pull request

• What does your PR fix?

  Fixes unicode support for curl

• Which triplets are supported/not supported? Have you updated the CI baseline?

  windows, No

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[microsoft-cla-retired[bot]]

All CLA requirements met.

[m-kuhn]

Should this be added to default features?

[rozdaybeda]

Should this be added to default features?

I think it should be enabled by default for windows

[JonLiu1993]

@rozdaybeda, Can you please resolve the conflicts against master?

[JonLiu1993]

@rozdaybeda, I agree with @autoantwort, can you revise it?

[JonLiu1993]

@rozdaybeda, These two suggestions should be adopted, what do you think? https://github.com/microsoft/vcpkg/pull/25865#discussion_r924470115 https://github.com/microsoft/vcpkg/pull/25865#discussion_r924470405

[rozdaybeda]

The first one doesn't fit and here's why: #25865 I think it makes sense to add only the second suggestion.

Thanks

[JonLiu1993]

All functions were successfully tested except for feature 'sectransp' in the following triples:

• x86-windows
• x64-windows

[BillyONeal]

I don't believe we can accept this because it's using a feature to control alternatives: https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/maintainer-guide.md#do-not-use-features-to-control-alternatives-in-published-interfaces

It may make sense to do unconditionally on Windows (which is why I'm not outright closing the PR).

I don't believe anything about this has been addressed.

To be clear, it can never be a requirement for correctness that a feature is not installed.

[rozdaybeda]

@BillyONeal does it work for you?

if(VCPKG_TARGET_IS_WINDOWS)
    list(APPEND OPTIONS -DENABLE_UNICODE=ON)
endif()

Or would that be better?

vcpkg_cmake_configure(
    SOURCE_PATH "${SOURCE_PATH}"
    OPTIONS 
        "-DCMAKE_PROJECT_INCLUDE=${CMAKE_CURRENT_LIST_DIR}/cmake-project-include.cmake"
        ${FEATURE_OPTIONS}
        ${OPTIONS}
        ...
	-DENABLE_UNICODE=ON
    OPTIONS_DEBUG
        -DENABLE_DEBUG=ON
)

[BillyONeal]

@BillyONeal does it work for you?

if(VCPKG_TARGET_IS_WINDOWS)
    list(APPEND OPTIONS -DENABLE_UNICODE=ON)
endif()

It works for me!

@bagder @MarcelRaad @apique Is there any reason we should not just turn this on unconditionally?

[MarcelRaad]

It doesn't do anything on non-Windows platforms, so turning it on unconditionally shouldn't hurt.

[BillyONeal]

Thanks for your contribution @rozdaybeda !