highlight #suppression for better suppression identification

[allenjzhang]

Clear and concise description of the problem

It would be nice to highlight #suppression line in editors for better identification when viewing.

Checklist

• [X] Follow our Code of Conduct
• [X] Read the docs.
• [X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[markcowl]

Priority: 1

[RodgeFu]

@timotheeguerin , I can't find a proper SemanticToken or scope in vscode for the highlight. do you have any suggestions? thanks.

[timotheeguerin]

sorry, I personally don't think this is a feature we want like that suppression are suppression it shouldn't be highlighted to the user if he meant to suppress them. They are also already too visibile IMO with the highlighting of #suppress keyword. This is just for the review of Azure service which woudln't even get done in VSCode with that highlighting. I think if we want that we need an opt-in option in the vscode settings and we can highlight them as suggestions or warnings or some other modifiers.

[RodgeFu]

Agree that from vs/vscode extension perspective, if user adds the suppress explicitly, he would expect the item to be ignored instead of highlighted. Also in c#, the #pragma warning disable ... or [SuppressMessage(...)] are both greyed out. so close the issue.

@allenjzhang , feel free to reopen if you still want them to be highlighted in vs/vscode extension for some reason. thanks.