testfx icon indicating copy to clipboard operation
testfx copied to clipboard

Upgrade target framework of PlatformServices.Portable project

Open parrainc opened this issue 7 years ago • 2 comments

Description

The target framework for the Portable project in ... should be upgraded to at least .net standard version 1.3.x or maybe the latest one.

Why? I'm trying to fix this issue #394 but unfortunately since .net standard implementation doesn't have Path.GetFullPath() method, I haven't been able to make the PR (to replicate the same behavior as in the full CLR implementation of the TestContext).

Steps to reproduce

Clone the testfx repo Open the TestFx sln Build it Go to PlatformServices.Portable project Open any of the ns10... files, and Try typing Path.GetFullPath() -- you will see warning next to method name, and intellisense stating that GetFullPath() method is not available.

Expected behavior

users should be able to use Path.GetFullPath() method across all the projects (Portable, NetCore, and Universal)

Actual behavior

Since target net standard version is 1.0.x or lower than 1.3.x, the Path.GetFullPath() and other methods are not implemented.

path-missing2

Environment

Windows 10, build 1803. Visual Studio 2017 MSTest V2 .Net Core 2.1.3

AB#1575898

parrainc avatar Aug 25 '18 03:08 parrainc

I'm available and dispose to work on this issue, but would need some help (i.e. what do i need to change in order to upgrade the target framework).

parrainc avatar Aug 25 '18 03:08 parrainc

This will be handled by #1095

Evangelink avatar Jul 12 '22 18:07 Evangelink

Fixed by #1163

Evangelink avatar Aug 25 '22 15:08 Evangelink