microsoft
Mica Alt
Description of the new feature/enhancement
Add Mica Alt support
Proposed technical implementation details (optional)
Eh, sure.
Hardest part would be changing the existing $theme.$window.useMica property in the settings from a straight boolean to one that also accepts a string enum. (ala bellStyle and BellStyle)
@mews6 u still working on this issue?
Yes, i am. I have been scouting the codebase to check where should i be changing stuff because this is my first time contributing to the project. I'm trying to formulate a good briefing of the changes to be done before i change anything in the code itself and there are already a few things I'm probably going to ask about, but I'm trying to check if there are any obvious responses to my questions before getting back here and asking those questions, if that makes any sense. Sorry if i have taken a bit longer for that, I'm just trying to get accustomed.
I'm currently trying to understand how the settings mentioned by @zadjii-msft work. Just reading documentation (mostly here) on how those terminal settings work and checking where Mica is mentioned in the repo (Which you can check here). I could certainly use a bit of guidance for where i should be changing stuff. It seems that useMica is declared as a function in https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/IslandWindow.cpp#L1934 and https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L1176
Among other places.
I'm not still sure if we should be changing both definitions, if there is anything else to be changed or if there are any other considerations i should have regarding this problem. That's the reason i haven't really talked much here, but rest assured i'm working on it and i'm open to feedback.
I think that u r in the perfect way to solve it! It's my first time here to, and if u wan't to discuss about it, I will be glad to help... I have some ideas to implement to...
Hmm, for some reason this issue is gathering quite a bit of attention
@zadjii-msft , what should we do about this?
I think you could just specify mica alt theme by giving DWMSBT_TABBEDWINDOW value to const attribute.
https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/IslandWindow.cpp#L1934
Following code block has called the function we modified.
https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L1176
@mews6 u still working on this issue?
Yes, i am. I have been scouting the codebase to check where should i be changing stuff because this is my first time contributing to the project. I'm trying to formulate a good briefing of the changes to be done before i change anything in the code itself and there are already a few things I'm probably going to ask about, but I'm trying to check if there are any obvious responses to my questions before getting back here and asking those questions, if that makes any sense. Sorry if i have taken a bit longer for that, I'm just trying to get accustomed.
I'm currently trying to understand how the settings mentioned by @zadjii-msft work. Just reading documentation (mostly here) on how those terminal settings work and checking where Mica is mentioned in the repo (Which you can check here). I could certainly use a bit of guidance for where i should be changing stuff. It seems that
useMicais declared as a function inhttps://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/IslandWindow.cpp#L1934
and https://github.com/microsoft/terminal/blob/56cfb77c6d2aeaa408310756ed711531a037c021/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L1176
Among other places. I'm not still sure if we should be changing both definitions, if there is anything else to be changed or if there are any other considerations i should have regarding this problem. That's the reason i haven't really talked much here, but rest assured i'm working on it and i'm open to feedback.
Hi @zadjii-msft, if this issue has been resolved then please close/mark it done
Hi zadjii-msft, if this issue has been resolved then please close/mark it done
@the-sky7 Having fully read and understood the comment thread, do you have any reason to believe that this issue is resolved?
Hey! I'd love to work on this issue as my contribution.
Could you please assign it to me? 😊
@Bhavika42 @dawoodshah04 you're welcome to work on this issue. Just submit a pull request when you're done. No need to assign someone to the work item. 😊 Thanks!
Hi! I’m a first-time contributor and would love to work on this issue. Could I please get it assigned to me?
@farheen-shaikh530 you're welcome to work on this issue. Just submit a pull request when you're done. No need to assign someone to the work item. 😊 Thanks!
Hey, I couldn’t fully understand the issue from the previous explanation. Can you please describe it again in a clearer way?
It would help if you could:
- Tell what exactly is going wrong
- Share any errors or unexpected behavior
- Add steps to reproduce (if possible)
- Include screenshots or logs if available
Thanks!
Hi, I'm a new contributor and would like to work on this issue. Please let me know if it's okay to proceed.
Hii, I would like to work on this issue. Could you please assign it to me?
For any and all people coming to this thread: we do not typically assign out issues, unless it's to a core team member who's job it is to work on that issue. For any community contributions, Code Wins. Just write it, and we'll merge it if it works.