semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

.Net: Add connector for AWS Bedrock

Open stephentoub opened this issue 2 years ago • 4 comments

https://docs.aws.amazon.com/sdkfornet/v3/apidocs/items/Bedrock/TBedrockClient.html

stephentoub avatar Dec 17 '23 11:12 stephentoub

After reading https://github.com/microsoft/semantic-kernel/issues/3094, I was wondering if there is still hope for the Bedrock connector to make it into the main repo? That would be soooo sweet 🙏

stekiri avatar Dec 21 '23 10:12 stekiri

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] avatar Apr 06 '24 01:04 github-actions[bot]

Hi @stephentoub do you need help with this one? I'd love to give it a hand.

I've authored this library https://github.com/fbouteruche/rockhead-extensions and I know how to work with AWS Bedrock.

fbouteruche avatar May 07 '24 13:05 fbouteruche

@markwallace-microsoft?

stephentoub avatar May 07 '24 13:05 stephentoub

@stephentoub @markwallace-microsoft We are planning to work on this. Could you please update the status regarding this issue.

as14692 avatar Jun 10 '24 18:06 as14692

@stephentoub @markwallace-microsoft We are planning to work on this. Could you please update the status regarding this issue.

Awesome. @markwallace-microsoft ?

stephentoub avatar Jun 10 '24 18:06 stephentoub

@stephentoub Should we plan to fork this repo and open a PR adding the Bedrock connectors here? https://github.com/microsoft/semantic-kernel/tree/main/dotnet/src/Connectors

Beau-Gosse-dev avatar Jun 13 '24 17:06 Beau-Gosse-dev

@Beau-Gosse-dev we'd be delighted to have this contribution. I'm adding @RogerBarreto as he has been working with contributors on some of the new connectors.

We will create a feature branch for this work to allow multiple smaller PR's which will be easier to review and merge. Some information about this process: https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0031-feature-branch-strategy.md

markwallace-microsoft avatar Jun 13 '24 17:06 markwallace-microsoft

@Beau-Gosse-dev, @as14692 please follow the instructions on our Feature Branch Strategy provided by @markwallace-microsoft above.

Feature branch for Amazon Bedrock was created, on the next PR's please target this branch https://github.com/microsoft/semantic-kernel/tree/feature-connectors-amazon

Consider initial namespace naming as Microsoft.SemanticKernel.Connectors.Amazon following similar folder and coding pattern (Client abstractions, Core, Services) used in our latest Google connector for Vertex AI.

Thanks for the contribution!

rogerbarreto avatar Jun 14 '24 09:06 rogerbarreto

Thanks so much @markwallace-microsoft and @RogerBarreto !

One question right away, will we be able to take a dependency on the AWS SDK for Bedrock? source code, nuget

Beau-Gosse-dev avatar Jun 14 '24 19:06 Beau-Gosse-dev

Thanks so much @markwallace-microsoft and @RogerBarreto !

One question right away, will we be able to take a dependency on the AWS SDK for Bedrock? source code, nuget

That should be fine

markwallace-microsoft avatar Jun 17 '24 10:06 markwallace-microsoft

I am also very interested in this. Will it suffice to add a class in the connectors namespace and implement IChatCompletion?

halllo avatar Jul 20 '24 08:07 halllo

@halllo , we're currently doing an internal review of these changes before submitting them to this main repo. We'd appreciate your feedback if you have any: https://github.com/as14692/semantic-kernel/pull/1

Beau-Gosse-dev avatar Jul 22 '24 21:07 Beau-Gosse-dev

@markwallace-microsoft @RogerBarreto @stephentoub Submitted first PR for ChatCompletionService and TextGenerationService. Please review.

as14692 avatar Jul 31 '24 22:07 as14692