semantic-kernel icon indicating copy to clipboard operation
semantic-kernel copied to clipboard

.Net: Issue 11564 (fix for local api description url filepath)

Open AleRoe opened this issue 9 months ago • 1 comments

Motivation and Context

Currently, CreatePluginFromApiManifestAsync does not work when referencing a local filepath for the apiDescriptionIUrl in the apiDependencies section. For details, see https://github.com/microsoft/semantic-kernel/issues/11564

Description

The fix involves setting the BasePath of the OpenApiStreamReader to the previously parsed url value instead of the original value. Unittests and sample data included.

Contribution Checklist

Hope this PR is suitable. Cheers, Alexander

AleRoe avatar Apr 25 '25 09:04 AleRoe

Cool, thanks

AleRoe avatar Apr 25 '25 11:04 AleRoe

Just fixed the "empty line error" that was prbventing the donten-build-and-test

AleRoe avatar May 02 '25 13:05 AleRoe

Dear @SergeyMenshykh , @RogerBarreto, I fixed the error with the extra line. Could you kindly start the merge again. Thanks!

AleRoe avatar May 03 '25 16:05 AleRoe

We are good to go, Engineer has confirmed that this does not break our work in CAPs @SergeyMenshykh

fabianwilliams avatar May 06 '25 13:05 fabianwilliams

Hi @SergeyMenshykh Thank you very much for accepting and integrating my fix! All the best, Alexander

AleRoe avatar May 06 '25 15:05 AleRoe