microsoft
fix the serialize bug when delete a Qdrant point
Motivation and Context
fixed the bug #970
Description
Contribution Checklist
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with
dotnet format - [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone :smile:
This seems to be doing more than fixing bug, and it's hard to see where any bug fix is happening. The UT added doesn't do any deletion of points. It seems like it's more about adding a new method ListPoints that should likely be part of the IMemoryStore interface and deserves a full proposal.
Abstract classes can not be deserialized. "Microsoft.SemanticKernel.Connectors.Memory.Qdrant.Http.ApiSchema.QdrantResponse" is an abstract class. So the bug happened
@EashShow would you mind splitting this PR in two parts, the part fixing the deserialization bug, and the other one adding a method to the IQdrantVectorDbClient interface ? Your fix would be dearly appreciated here 🙏
@EashShow would you mind splitting this PR in two parts, the part fixing the deserialization bug, and the other one adding a method to the
IQdrantVectorDbClientinterface ? Your fix would be dearly appreciated here 🙏
Yes, no problem
When can we expect a new version of the NuGet packages?
This is something that we are needing.
The original bug #970 has already been fixed, and what remains here is mostly documentation and additional functionality. @EashShow closing the PR, but if you feel the other changes are valuable, please re-submit with description of added features and new tests.
