rushstack icon indicating copy to clipboard operation
rushstack copied to clipboard

[rush-lib] Add rush remove

Open sherlockfeng opened this issue 3 years ago • 2 comments

Provide a "rush remove" command that undoes "rush add" https://github.com/microsoft/rushstack/issues/1457

sherlockfeng avatar Aug 16 '22 10:08 sherlockfeng

pipeline failed seemed not relative to my change

sherlockfeng avatar Aug 16 '22 11:08 sherlockfeng

This looks mostly okay, for one exception:

Scenario: A project contains (hypothetically) a dependency that is listed as both dependency of different types (peer & devDep || etc.). How should the user proceed here.

Perhaps it's good to add a case like this to your unit tests. Otherwise some changes around removing variant (unless cc @octogonz corrects me) its not relevant in removing dependencies but rather updating/adding/installing.

@TheLarkInn i add a case in my unit tests, rush remove will remove all type of dependency like pnpm remove

sherlockfeng avatar Sep 07 '22 02:09 sherlockfeng

Look's great now. Thank you for this contribution 🙏

TheLarkInn avatar Oct 04 '22 19:10 TheLarkInn