retina icon indicating copy to clipboard operation
retina copied to clipboard

remove irrelevant metric labels for dns and apiserver latency

Open vakalapa opened this issue 1 year ago • 2 comments

If my understanding is correct, these labels seem irrelevant to these metrics.

DNS

Seems like DNS request doesn't need num_response, response, or return_code.

networkobservability_dns_request_count{num_response="0",query="wpad.svc.cluster.local.",query_type="A",response="",return_code=""} 354

API Server Latency

Remove count label from adv_node_apiserver_no_response. Only possible time series for this metric right now is:

adv_node_apiserver_no_response{count="no_response"}

See latency.go

vakalapa avatar Mar 19 '24 16:03 vakalapa

@vakalapa can I take this

iamrajhans avatar Mar 20 '24 09:03 iamrajhans

Sure assigning this to you. Ease feel free to ask any questions you might have.

vakalapa avatar Mar 20 '24 14:03 vakalapa