retina icon indicating copy to clipboard operation
retina copied to clipboard

optimize build pipeline to minimize code duplication.

Open jimassa opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe. There are 3 pipelines that build the images and use the same gh action code

  • build https://github.com/microsoft/retina/blob/main/.github/workflows/images.yaml
  • release https://github.com/microsoft/retina/blob/main/.github/workflows/release-images.yaml
  • e2e https://github.com/microsoft/retina/blob/main/.github/workflows/integration.yaml

Describe the solution you'd like A good solution will be to create a template that will reuse the code and pass parameters based on what is needed in each pipeline.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

jimassa avatar Mar 25 '24 21:03 jimassa

While I agree a GH composite action for these duplicate steps would help in reducing boilerplate-ness, I think the current implementation which expose all the build steps is very readable and comprehensive. In additional, I feel like the template could turn into a very complex one once more parameters are added as build steps deviating from each other.

Just my 2cent regarding this :D

hainenber avatar Mar 28 '24 14:03 hainenber