react-native-windows icon indicating copy to clipboard operation
react-native-windows copied to clipboard

Fix accessibilityValue & ensure narrator announces changes

Open agniuks opened this issue 3 years ago • 0 comments

Description

This PR adds UIA events when accessibilityValue has changed which will ensure that accessibility clients like Narrator can announce these types of changes to the user.

In addition, while working on this issue I found that accessibilityValue max/min/now values had not been working for a while because of some missed parentheses in a viewmanager refactoring, fixed that as well.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Why

Resolves: https://github.com/microsoft/react-native-windows/issues/10284

Fix accessibilityValue.

What

What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.

  • added UIA events so that changes are announced by narrator
  • general implementation fixes: proper initialization as double values for min/max/now, added in missing parentheses, fixed min/max improperly listed as bools, added logic to clear values when they are removed in js.

Testing

Added examples to rntester, and confirmed that accessibilityValue works and changes are announced by narrator.

Microsoft Reviewers: Open in CodeFlow

agniuks avatar Jul 26 '22 20:07 agniuks