react-native-code-push icon indicating copy to clipboard operation
react-native-code-push copied to clipboard
verified publisher icon microsoft

Bump minimum Windows SDK version to 10.0.17763.0

Open VMBindraban opened this issue 2 years ago • 4 comments

Fixes https://github.com/microsoft/react-native-code-push/issues/2624

VMBindraban avatar Nov 29 '23 09:11 VMBindraban

@VMBindraban , are you still interested in this PR?

DmitriyKirakosyan avatar Jun 05 '24 08:06 DmitriyKirakosyan

We moved away from codepush a couple of weeks ago since it's being retired and there is no alternative setup yet. This PR is still required for people that use codepush with react-native-windows.

VMBindraban avatar Jun 05 '24 08:06 VMBindraban

@VMBindraban, thanks for the update.

Did you test the changes when you prepared this PR? Do you remember why you removed the entire <PropertyGroup Label="Configuration"> section? Was it not needed?

DmitriyKirakosyan avatar Jun 10 '24 05:06 DmitriyKirakosyan

I tested the changes at the time yes.

Regarding removal of the section, i don't remember why i removed it. I was using Visual studio 2022 at the time. (v143) Visual Studio 2019 (V142) is now EOL.

VMBindraban avatar Jun 10 '24 07:06 VMBindraban

https://github.com/microsoft/react-native-code-push/pull/2719 is merged. Closing this. @VMBindraban thank you for the contribution!

DmitriyKirakosyan avatar Jul 08 '24 05:07 DmitriyKirakosyan