react-native-code-push icon indicating copy to clipboard operation
react-native-code-push copied to clipboard

Some assets are not getting bundled in codepush

Open AmitSingh12345678 opened this issue 2 years ago • 18 comments

Steps to Reproduce

1.init project and install react-native-code-push package 2. Using a asset of format lottie(abc.lottie) like this: {require('/abc.lottie')} 3. code-push release

Expected Behavior

Every assets including dotlottie format should work fine.

Actual Behavior

Everything works fine, except dotlottie format assets are not showing after codepush release, but was working fine in debug and release mode.

Environment

  • react-native-code-push version: 8.0.0
  • react-native version: 0.71.11
  • iOS/Android/Windows version: 13
  • appcenter version: 2.13.4
  • Does this reproduce on a debug build or release build? release
  • Does this reproduce on a simulator, or only on a physical device? physical device.

AmitSingh12345678 avatar Nov 08 '23 19:11 AmitSingh12345678

We are facing this as well, our hunch is that codepush release-react while bundling the JS doesn't respect the local metro.config.js where we have specified how to resolve certain asset extensions (.lottie)

bhavzie avatar Nov 09 '23 13:11 bhavzie

We're also facing this. When codepush bundle gets replaced. Lottie is no longer being visible.

manikandanb24 avatar Nov 20 '23 11:11 manikandanb24

Yep same here, however it is only on Android where the .lottie files do not work

walterholohan avatar Nov 22 '23 10:11 walterholohan

Yep same here, however it is only on Android where the .lottie files do not work

The reason is because on Android release mode, react native bundles all the assets in raw folder whearas on iOS it uses network call. Seems like mostly code push is the problem. Has anyone tried expo updates? Is it the same story there?

matinzd avatar Nov 23 '23 13:11 matinzd

On my project I use react-native-asset to solve this problem, it took a decent amount of time, as there were more than 800 asset files

a-petrenko-muse avatar Nov 28 '23 12:11 a-petrenko-muse

On my project I use react-native-asset to solve this problem, it took a decent amount of time, as there were more than 800 asset files

@a-petrenko-muse Can you please tell what is this issue with codepush and how do you get to know that react-native-asset will solve this problem?

AmitSingh12345678 avatar Nov 28 '23 17:11 AmitSingh12345678

+1

mrtawil avatar Dec 02 '23 00:12 mrtawil

Are there any updates?

hardik-flyfin avatar Dec 06 '23 08:12 hardik-flyfin

+1

joaojoseleal avatar Dec 28 '23 01:12 joaojoseleal

Could you please confirm what this issue still persist on latest version (8.2.1)? If no could you please confirm that the problem persists when linking assets using react-native-asset package?

MikhailSuendukov avatar Jan 29 '24 15:01 MikhailSuendukov

Active

hardik-flyfin avatar Apr 01 '24 03:04 hardik-flyfin

+1

quoctruongkt avatar Apr 26 '24 01:04 quoctruongkt

I am also stuck because of this problem. Has anyone handled it yet?

quoctruongkt avatar Apr 26 '24 07:04 quoctruongkt

Tôi cũng bị mắc kẹt vì vấn đề này. Đã có ai xử lý được chưa?

me too :(

ToanMonkey avatar May 03 '24 08:05 ToanMonkey

@hardik-flyfin, @quoctruongkt, @ToanMonkey, please share information about the versions of CodePush and ReactNative. Please try using react-native-asset as a workaround.

DmitriyKirakosyan avatar May 17 '24 08:05 DmitriyKirakosyan

@hardik-flyfin, @quoctruongkt, @ToanMonkey, please share information about the versions of CodePush and ReactNative. Please try using react-native-asset as a workaround.

I initially used -Code push: 7.1.0 -React Native : 0.70.6 Currently I have upgraded to React Native: 0.71.19 but still have the same problem

ToanMonkey avatar May 17 '24 09:05 ToanMonkey

@ToanMonkey please try updating codepush to 8.2.2

DmitriyKirakosyan avatar May 20 '24 09:05 DmitriyKirakosyan

@ToanMonkey please try updating codepush to 8.2.2

I tried updating codepush to version 8.2.2 but the problem is still not resolved

quoctruongkt avatar May 21 '24 01:05 quoctruongkt

It would be greatly appreciated if anyone could provide a demo application to reproduce and debug the issue.

DmitriyKirakosyan avatar Jul 05 '24 10:07 DmitriyKirakosyan

Closing due to inactivity.

DmitriyKirakosyan avatar Jul 19 '24 05:07 DmitriyKirakosyan

+1

tevfik1 avatar Aug 20 '24 23:08 tevfik1