react-native-code-push icon indicating copy to clipboard operation
react-native-code-push copied to clipboard

Instance jsBundleURLForBundleRoot with fallbackExtension

Open JulioCVaz opened this issue 2 years ago • 1 comments

Sumary

In react-native 0.70 was updated file RCTBundleURLProvider and removed fallbackResource in jsBundleURLForBundleRoot method instance. The incorrect import cause problems during build with react-native-code-push. Now is need to use fallbackExtension instead fallbackResource.

Reference: https://github.com/facebook/react-native/blob/a69bc7f1fd1f914b98beb665fc9e688673742611/CHANGELOG-pre-070.md?plain=1#L472

JulioCVaz avatar Sep 01 '23 18:09 JulioCVaz

@microsoft-github-policy-service agree

JulioCVaz avatar Sep 01 '23 18:09 JulioCVaz

@JulioCVaz, please resolve the conflicts. The documentation was partly updated, causing conflicts with your changes. Additionally, please remove fallbackExtension as it is not required.

Regarding the DemoApp, I don't think we need to modify the code in it, as it still uses an older version of react-native.

DmitriyKirakosyan avatar Jun 05 '24 08:06 DmitriyKirakosyan

@JulioCVaz, please resolve the conflicts. The documentation was partly updated, causing conflicts with your changes. Additionally, please remove fallbackExtension as it is not required.

Regarding the DemoApp, I don't think we need to modify the code in it, as it still uses an older version of react-native.

Hey @DmitriyKirakosyan thank you for the update. Done in https://github.com/microsoft/react-native-code-push/pull/2577/commits/29bbdf486ec17826e7acbae1bf538620bff16ba8

JulioCVaz avatar Jun 06 '24 03:06 JulioCVaz

@JulioCVaz Let's remove fallbackExtension:nil part, as it is not needed.

DmitriyKirakosyan avatar Jun 07 '24 10:06 DmitriyKirakosyan

@JulioCVaz Let's remove fallbackExtension:nil part, as it is not needed.

Perfect @DmitriyKirakosyan I think so this PR is not more necessary :)

JulioCVaz avatar Jun 09 '24 23:06 JulioCVaz

@JulioCVaz , you’re right. All the code parts with fallbackResource are under RN <0.70 blocks, so we can close this PR. Thanks a lot for your time and effort in contributing!

DmitriyKirakosyan avatar Jun 10 '24 03:06 DmitriyKirakosyan