react-native-code-push icon indicating copy to clipboard operation
react-native-code-push copied to clipboard

Remove jcenter

Open owjsub opened this issue 3 years ago • 5 comments

"Based on the current timeline, builds that use JCenter will be able to resolve dependencies until February 1, 2022 without changes. After that date, there are no guarantees that you will be able to build your software if you continue to use JCenter." --https://blog.gradle.org/jcenter-shutdown

https://github.com/microsoft/react-native-code-push/issues/2213

owjsub avatar Jan 31 '22 17:01 owjsub

Can anyone merge this pr?

BogdanRad avatar Feb 01 '22 12:02 BogdanRad

This ticket should be closed after the PR ^^ was merged

andresesfm avatar Apr 05 '22 17:04 andresesfm

Anyone know when this will be merged in?

je7ov avatar May 12 '22 17:05 je7ov

@je7ov as a workaround you can use patch-package to patch the fix yourself while this PR is not yet merged.

Here's the diff

 buildscript {
     repositories {
-        jcenter()
+        google()
+        mavenCentral()
     }
     dependencies {
         classpath 'com.android.tools.build:gradle:1.3.0'
@@ -15,6 +16,6 @@ buildscript {
 allprojects {
     repositories {
         mavenLocal()
-        jcenter()
+        mavenCentral()
     }
 }

pedpess avatar May 13 '22 09:05 pedpess

Change landed in 7.0.5, so I think this issue can be closed? @gabrielluka @BogdanRad

https://github.com/microsoft/react-native-code-push/compare/v7.0.4...v7.0.5

pedpess avatar Sep 21 '22 13:09 pedpess

Please merge this. v7.0.5 does not include this change

https://github.com/microsoft/react-native-code-push/blob/master/android/build.gradle#L5

https://github.com/microsoft/react-native-code-push/blob/master/android/build.gradle#L18

vTrip avatar Oct 31 '22 03:10 vTrip

Is there a timeline for adding this in? We'd really like to remove any dependencies on jcenter from our app.

huynhtastic avatar Apr 04 '23 19:04 huynhtastic