react-native-code-push icon indicating copy to clipboard operation
react-native-code-push copied to clipboard

add timeout parameter on checkForUpdate

Open b3coded opened this issue 4 years ago • 4 comments

Summary

Added checkUpdateTimeout property (like Axios does). It makes the developer prevent app for waiting too much time for checkForUpdate method. I haven't the screenshot now but used Flipper to see my Network requests and the route to check update ended in approximately 64 seconds.

Added checkUpdateTimeout in react-native-code-push.d.ts

Fixes #2032

Breaking change

  • checkForUpdate second parameter is now checkUpdateTimeout, handleBinaryVersionMismatchCallback is now the third parameter

b3coded avatar Apr 09 '21 19:04 b3coded

CLA assistant check
All CLA requirements met.

ghost avatar Apr 09 '21 19:04 ghost

hi

what about this fix ? i can t see this checkUpdateTimeout param available in 7.0.4 version ?

thanks

smolleyes avatar Mar 24 '22 12:03 smolleyes

Push this is a nice feature

NilsBaumgartner1994 avatar May 11 '22 21:05 NilsBaumgartner1994

Will this feature be coming? I have noticed much longer wait times on calling checkForUpdate which really slows down the app on launch.

harlin22 avatar Jun 14 '22 17:06 harlin22

We are not planning to introduce any breaking changes.

velimir-jankovic avatar Nov 08 '23 12:11 velimir-jankovic