qlib icon indicating copy to clipboard operation
qlib copied to clipboard

fix position access error

Open lerit opened this issue 3 years ago • 3 comments

position is a subproperty of _value,cash and now_account_value belongs to _value.position maybe error since:https://github.com/microsoft/qlib/pull/1120

lerit avatar Aug 25 '22 16:08 lerit

Thanks for your contributions!

Please fix the CI error.

you-n-g avatar Aug 29 '22 09:08 you-n-g

Thanks for your contribution. This reflex another flaw of our CI that it can't detect the errors in the report. So I think it would be better to add such a check in our CI. (It may be some command like jupyter nbconvert workflow_by_code.ipynb)

Would you like to contribute to this feature in this PR?

Otherwise, @SunsetWolf will help with this feature.

you-n-g avatar Aug 29 '22 10:08 you-n-g

I have fix the CI error. @you-n-g

lerit avatar Aug 30 '22 03:08 lerit

It looks great. Thanks for your contribution.

you-n-g avatar Nov 08 '22 02:11 you-n-g