python-language-server icon indicating copy to clipboard operation
python-language-server copied to clipboard

Many (most?) files don't conform to the project's .editorconfig

Open leungbk opened this issue 5 years ago • 1 comments

On Linux, with the Editorconfig plugin for Emacs enabled, whenever I make a change inside a .cs file contained in this project, I notice that I generate a lot of ^M characters (when before there were none) unless I set end_of_line = lf in the project's .editorconfig, which currently has end_of_line = crlf.

Based on the .editorconfig, I would have expected all the files to already have ^M characters terminating each line.

leungbk avatar Jul 01 '20 04:07 leungbk

This seems like an interplay between git's choice of line endings and the config, where it's checking it out as LF, not CRLF. We've typically worked on Windows in VS, where git by default will use CRLF when pulling down (so VS would not perceive any problems with formatting).

On Linux, it's likely checking it out as LF so the editorconfig is wrong. Arguably the config should just be removed; the tests normalize things or otherwise don't care about the encoding of their files.

jakebailey avatar Jul 01 '20 18:07 jakebailey