promptflow icon indicating copy to clipboard operation
promptflow copied to clipboard

new error message and test

Open MilesHolland opened this issue 1 year ago • 7 comments

Adds some extra error checking to when we try to load an evaluator to recognize when a loaded evaluator has relative imports (which fail post-load in a non-trivial-to-fix way due to how our save/load system works). When this error is recognized, the resulting user-facing message is a bit more detailed to help user's fix their evaluator.

Also adds a test to ensure that this works as expected.

MilesHolland avatar Aug 07 '24 18:08 MilesHolland

promptflow SDK CLI Azure E2E Test Result relative-import-error-message

  4 files    4 suites   4m 21s :stopwatch: 244 tests 204 :white_check_mark:  40 :zzz: 0 :x: 976 runs  816 :white_check_mark: 160 :zzz: 0 :x:

Results for commit 011cecab.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 07 '24 18:08 github-actions[bot]

promptflow-core test result

0 tests   0 :white_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 011cecab.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 07 '24 18:08 github-actions[bot]

SDK CLI Global Config Test Result relative-import-error-message

6 tests   6 :white_check_mark:  1m 24s :stopwatch: 1 suites  0 :zzz: 1 files    0 :x:

Results for commit 011cecab.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 07 '24 18:08 github-actions[bot]

Executor Unit Test Result relative-import-error-message

798 tests   798 :white_check_mark:  3m 45s :stopwatch:   1 suites    0 :zzz:   1 files      0 :x:

Results for commit 011cecab.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 07 '24 18:08 github-actions[bot]

Executor E2E Test Result relative-import-error-message

246 tests   240 :white_check_mark:  5m 17s :stopwatch:   1 suites    6 :zzz:   1 files      0 :x:

Results for commit 011cecab.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 07 '24 18:08 github-actions[bot]

promptflow-evals test result

   12 files  ± 0     12 suites  ±0   19m 34s :stopwatch: -48s   117 tests + 1    117 :white_check_mark: + 1  0 :zzz: ±0  0 :x: ±0  1 404 runs  +12  1 404 :white_check_mark: +12  0 :zzz: ±0  0 :x: ±0 

Results for commit 011cecab. ± Comparison against base commit d5cc19c2.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 07 '24 18:08 github-actions[bot]

SDK CLI Test Result relative-import-error-message

    4 files      4 suites   1h 7m 38s :stopwatch:   790 tests   767 :white_check_mark: 23 :zzz: 0 :x: 3 160 runs  3 068 :white_check_mark: 92 :zzz: 0 :x:

Results for commit 011cecab.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 07 '24 18:08 github-actions[bot]

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Sep 19 '24 21:09 github-actions[bot]

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

github-actions[bot] avatar Sep 26 '24 21:09 github-actions[bot]