promptflow icon indicating copy to clipboard operation
promptflow copied to clipboard

PFServing otlp support improvement

Open wxpjimmy opened this issue 1 year ago • 6 comments

…support otlp log exporter

Description

  • change metrics dimension default value from none to "", this is to avoid otlp metrics encode failure
  • change both http and grpc otlp collector
  • support otlp and app insight log exporter

All Promptflow Contribution checklist:

  • [X] The pull request does not introduce [breaking changes].
  • [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [ ] I have read the contribution guidelines.
  • [ ] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • [ ] Title of the pull request is clear and informative.
  • [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

wxpjimmy avatar May 17 '24 10:05 wxpjimmy

promptflow SDK CLI Azure E2E Test Result xiaopwan/pfserving_otlp_support_improvement

  4 files    4 suites   4m 8s :stopwatch: 243 tests 203 :white_check_mark:  40 :zzz: 0 :x: 972 runs  812 :white_check_mark: 160 :zzz: 0 :x:

Results for commit 543556af.

github-actions[bot] avatar May 17 '24 10:05 github-actions[bot]

promptflow-core test result

0 tests   0 :white_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 543556af.

github-actions[bot] avatar May 17 '24 10:05 github-actions[bot]

SDK CLI Global Config Test Result xiaopwan/pfserving_otlp_support_improvement

6 tests   6 :white_check_mark:  1m 12s :stopwatch: 1 suites  0 :zzz: 1 files    0 :x:

Results for commit 543556af.

github-actions[bot] avatar May 17 '24 10:05 github-actions[bot]

Executor Unit Test Result xiaopwan/pfserving_otlp_support_improvement

796 tests   796 :white_check_mark:  3m 44s :stopwatch:   1 suites    0 :zzz:   1 files      0 :x:

Results for commit 543556af.

github-actions[bot] avatar May 17 '24 10:05 github-actions[bot]

Executor E2E Test Result xiaopwan/pfserving_otlp_support_improvement

246 tests   240 :white_check_mark:  5m 2s :stopwatch:   1 suites    6 :zzz:   1 files      0 :x:

Results for commit 543556af.

github-actions[bot] avatar May 17 '24 10:05 github-actions[bot]

SDK CLI Test Result xiaopwan/pfserving_otlp_support_improvement

    4 files      4 suites   1h 5m 21s :stopwatch:   783 tests   740 :white_check_mark:  43 :zzz: 0 :x: 3 132 runs  2 960 :white_check_mark: 172 :zzz: 0 :x:

Results for commit 543556af.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 17 '24 10:05 github-actions[bot]