promptflow icon indicating copy to clipboard operation
promptflow copied to clipboard

fix: make test-flow-run-resume-from-token more stable

Open elliotzh opened this issue 2 years ago • 3 comments

Description

Previous resume test requires that:

  1. the original run is partially successful - success rate is neither 0 nor 100%
  2. the new run succeed on at least 1 failed record So there is always some probability that the test may fail.

This patch:

  1. loop until the original run is partially successful
  2. use token usage to gate the test

All Promptflow Contribution checklist:

  • [x] The pull request does not introduce [breaking changes].
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.
  • [x] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

elliotzh avatar Apr 28 '24 02:04 elliotzh

promptflow SDK CLI Azure E2E Test Result zhangxingzhi/fix-test-flow-run-resume-from-token

  4 files    4 suites   4m 6s :stopwatch: 238 tests 203 :white_check_mark:  35 :zzz: 0 :x: 952 runs  812 :white_check_mark: 140 :zzz: 0 :x:

Results for commit b1a354eb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 28 '24 02:04 github-actions[bot]

SDK CLI Global Config Test Result zhangxingzhi/fix-test-flow-run-resume-from-token

6 tests   6 :white_check_mark:  1m 17s :stopwatch: 1 suites  0 :zzz: 1 files    0 :x:

Results for commit b1a354eb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 28 '24 02:04 github-actions[bot]

SDK CLI Test Result zhangxingzhi/fix-test-flow-run-resume-from-token

    4 files      4 suites   57m 35s :stopwatch:   673 tests   632 :white_check_mark: 13 :zzz:  28 :x: 2 692 runs  2 537 :white_check_mark: 52 :zzz: 103 :x:

For more details on these failures, see this check.

Results for commit b1a354eb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 28 '24 03:04 github-actions[bot]

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar May 22 '24 21:05 github-actions[bot]

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

github-actions[bot] avatar May 29 '24 21:05 github-actions[bot]