opensource.microsoft.com icon indicating copy to clipboard operation
opensource.microsoft.com copied to clipboard

updated 25 files. updated all the missing names/logos of a few recent FOSS Fund Winners.

Open balajik10 opened this issue 3 years ago • 17 comments

updated all the missing names/logos of a few recent FOSS Fund Winners. and did corrections in existing files. hope this may help.

thank you.

balajik10 avatar Apr 24 '22 06:04 balajik10

CLA assistant check
All CLA requirements met.

ghost avatar Apr 24 '22 06:04 ghost

Can you please explain me what is CLA before I sign in.

balajik10 avatar Apr 24 '22 06:04 balajik10

Wow. This was quick. Thank you! I will have a look at it as soon as I can.

Can you please explain me what is CLA before I sign in.

It's the Contribution License Agreement. It gives certain license rights of your work ob this repository to Microsoft. You can read through it when you click on the link. After you've read it you can just sign in with your GitHub account and accept the agreement.

noraa-junker avatar Apr 24 '22 07:04 noraa-junker

now I am in the CLA page, there I have two options ,

  1. I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

  2. I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

which one should I select.

Thank you

balajik10 avatar Apr 24 '22 07:04 balajik10

now I am in the CLA page, there I have two options ,

  1. I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

  2. I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

which one should I select.

Thank you

Depends. If you're doing this PR on behalf of your work select 2. If not 1.

noraa-junker avatar Apr 24 '22 07:04 noraa-junker

I think I should go with option 1, because I am a student and learning about open source project. if I am right then please say proceed.

Thank you

balajik10 avatar Apr 24 '22 07:04 balajik10

I think I should go with option 1, because I am a student and learning about open source project. if I am right then please say proceed.

Thank you

Good then proceed with option 1.

noraa-junker avatar Apr 24 '22 07:04 noraa-junker

THANK YOU SIR , for guiding me in this issue.

balajik10 avatar Apr 24 '22 07:04 balajik10

THANK YOU SIR , for guiding me in this issue.

You're welcome.

noraa-junker avatar Apr 24 '22 07:04 noraa-junker

@Aaron-Junker thanks for your amazing support in this issue! @balajik10 I will review this PR tomorrow (April 18th) super appreciated.

emmairwin avatar Apr 27 '22 18:04 emmairwin

thank you for the appreciation . I hope my work helps you.

balajik10 avatar Apr 28 '22 06:04 balajik10

@balajik10 did you want to update your PR as per comments? If not then I can see about getting it done on my side. Thanks!

emmairwin avatar May 09 '22 17:05 emmairwin

yes , of course . I am bit occupied because of my exams . once I am done with it , I will get the work done.

balajik10 avatar May 10 '22 01:05 balajik10

awesome! No worries, I just wanted to make sure you were still there, good luck with your exams!

On Mon, May 9, 2022 at 6:39 PM BALAJI K @.***> wrote:

yes , of course . I am bit occupied because of my exams . once I am done with it , I will get the work done.

— Reply to this email directly, view it on GitHub https://github.com/microsoft/opensource.microsoft.com/pull/201#issuecomment-1121774283, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOZSXC4XPJFWTO3BXAJS3VJG43TANCNFSM5UFZXL2A . You are receiving this because you commented.Message ID: @.***>

-- -- Emma Irwin

emmairwin avatar May 10 '22 17:05 emmairwin

why is this PR not closed? are there any issues? If there are any, I can fix them.

santoshmanaguli avatar Jul 03 '22 09:07 santoshmanaguli

@santoshmanaguli we are waiting on a new commit to fix the typos. Until they get fixed we won't approve and merge.

jamesiri avatar Jul 08 '22 21:07 jamesiri

To clarify, this PR has two major updates required to merge.

  1. All the image links are broken (see image), this is happening, , because an image name was added to the yml, but there is no corresponding image in the folder. In the PR review, I provided URLs to the logos we should reference As I did here with curl, so it should be pretty quick. Please build locally (Jekyll instructions on the main page here) to validate the results yourself.

image

  1. Typos (see image 2 as example Barbel instead of Babel) image

We now have a few more FOSS Fund winners, on top of these, to get to, so if no one can take this by Monday, I will update and then open a new issue for new FOSS Fund winners, for someone to learn from .

thanks!

emmairwin avatar Jul 29 '22 00:07 emmairwin

New PR #226

emmairwin avatar Sep 02 '22 21:09 emmairwin