Improve names of .node files

Open Bashamega opened this issue 11 months ago • 4 comments

fix #701

Mar 14 '25 12:03 Bashamega

Hello @Tyriar I don't know why it is not working, it is working on Linux and Mac. I don't know c++ or how this project is built. Can you help me? Thanks.

Mar 14 '25 14:03 Bashamega

That error means that the expected compile .node file isn't there, so the change in binding.gyp didn't seem to do the right file or something. I don't have time to look into this further atm unfortunately.

Mar 14 '25 15:03 Tyriar

That error means that the expected compile .node file isn't there, so the change in binding.gyp didn't seem to do the right file or something. I don't have time to look into this further atm unfortunately.

I will try to look at it more

Mar 14 '25 15:03 Bashamega

There is one another place to update https://github.com/microsoft/node-pty/blob/bfbd94375c4d574338bb94c6decb2aeb39c50f55/src/win/conpty.cc#L171 and that should fix the failing tests.

Mar 17 '25 11:03 deepak1556