mu_plus icon indicating copy to clipboard operation
mu_plus copied to clipboard

Support the platform specific event hooks which can be customized.

Open Eathonhsu opened this issue 1 year ago • 4 comments

Description

The current event triggers lack flexibility and cannot be effectively used on some platforms.

  1. Create hook functions at the end of dxe event before and after the event.
  2. Create a hook after the boot manager dispatch the deferred 3rd party images Event.
  • [x] Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact on an application, flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
  • [x] Breaking change?
    • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • [ ] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

It will not affect the original process, mainly serving as an extension for platform use.

Integration Instructions

Create a new library to be replaced by the platform to expand functionality.

Eathonhsu avatar Apr 17 '24 07:04 Eathonhsu

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 12.00%. Comparing base (cd7ce3e) to head (2cf4944).

Files Patch % Lines
.../BdsPlatformEventLibNull/BdsPlatformEventLibNull.c 0.00% 13 Missing :warning:
...rePkg/Library/PlatformBootManagerLib/BdsPlatform.c 0.00% 4 Missing :warning:
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/202311     #469      +/-   ##
==================================================
- Coverage           12.01%   12.00%   -0.02%     
==================================================
  Files                 110      111       +1     
  Lines               19003    19019      +16     
  Branches             1735     1735              
==================================================
  Hits                 2283     2283              
- Misses              16674    16690      +16     
  Partials               46       46              
Flag Coverage Δ
MfciPkg 38.51% <ø> (ø)
MsCorePkg 1.42% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 17 '24 07:04 codecov-commenter

@Eathonhsu can you please fill out the Description details?

apop5 avatar Apr 18 '24 04:04 apop5

@Eathonhsu can you please fill out the Description details?

Updated, thanks for the suggestion

Eathonhsu avatar Apr 19 '24 01:04 Eathonhsu

@Eathonhsu can you please fill out the Description details?

Updated, thanks for the suggestion

I added the "breaking change" because this would require existing platforms to include a new library instance in their project to allow this to build.

apop5 avatar Apr 19 '24 01:04 apop5

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Jun 21 '24 23:06 github-actions[bot]

This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

github-actions[bot] avatar Jun 28 '24 23:06 github-actions[bot]