mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

[202405][Rebase&&FF] Variable Policy Changes

Open Flickdm opened this issue 1 year ago • 1 comments

Preface

Description

Cherry Picks: 1fc9ff0859 28789f8177 b4a8d2ea85 c61a571ca7 097ba36596 a8c4697c22 68670a0cef 28ec22916a 0549e53278 80d8796400 dac933023a 7a8dba5bfd 5b46552d23 43530fa937 521a898857 aeb50c2c7b 1a63f67

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

  • [ ] Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact on an application, flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
  • [ ] Breaking change?
    • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • [ ] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

<Please describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

Flickdm avatar Jun 26 '24 21:06 Flickdm

Codecov Report

Attention: Patch coverage is 3.63636% with 106 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@1a3fe3e). Learn more about missing BASE report.

Files Patch % Lines
.../Variable/RuntimeDxe/VariablePolicyLockingCommon.c 0.00% 68 Missing :warning:
...odulePkg/Library/UefiBootManagerLib/BmLoadOption.c 0.00% 27 Missing :warning:
...rsal/MonotonicCounterRuntimeDxe/MonotonicCounter.c 0.00% 4 Missing :warning:
...ModulePkg/Universal/Variable/RuntimeDxe/Variable.c 25.00% 3 Missing :warning:
...ulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c 0.00% 2 Missing :warning:
...ePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c 0.00% 1 Missing :warning:
...iversal/Variable/RuntimeDxe/VariablePolicySmmDxe.c 0.00% 1 Missing :warning:
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #978   +/-   ##
=================================================
  Coverage                  ?    0.98%           
=================================================
  Files                     ?      940           
  Lines                     ?   316802           
  Branches                  ?     3630           
=================================================
  Hits                      ?     3128           
  Misses                    ?   313596           
  Partials                  ?       78           
Flag Coverage Δ
MdeModulePkg 0.68% <3.63%> (?)
NetworkPkg 0.55% <ø> (?)
UefiCpuPkg 4.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 04 '24 00:07 codecov-commenter