mu_basecore icon indicating copy to clipboard operation
mu_basecore copied to clipboard

EccCheck update to later tools. Change EccCheck plugin scope. Add EccCheck

Open apop5 opened this issue 1 year ago • 1 comments

Description

EccCheck is a tool that verifies additional Efi Code Compatibility for files that have been modified.

EccCheck relies on the basetool/Source/Python/Ecc. Ecc contained files that were generated for parsing C files, but these were tied antlr4-runtime 4.7.1.

Documented instructions for generating new Ecc parser files/

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

  • [ ] Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • [ ] Impacts security?
    • Security - Does the change have a direct security impact on an application, flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ...
  • [ ] Breaking change?
    • Breaking change - Will anyone consuming this change experience a break in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ...
  • [ ] Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • [ ] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ...

How This Was Tested

Ran tests locally on repo after adding scope cibuild-edk2 Modified different files within packages to see if CI error would be tripped.

Integration Instructions

If wanting to use the EccCheck plugin, add cibuild-edk2 to the scope of the build files.

apop5 avatar Mar 14 '24 23:03 apop5

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 1.23%. Comparing base (09be074) to head (3452c51). Report is 1 commits behind head on release/202311.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311     #770   +/-   ##
===============================================
  Coverage            1.23%    1.23%           
===============================================
  Files                1302     1302           
  Lines              332084   332084           
  Branches             6683     6683           
===============================================
  Hits                 4117     4117           
  Misses             327891   327891           
  Partials               76       76           
Flag Coverage Δ
MdeModulePkg 0.69% <ø> (ø)
MdePkg 5.37% <ø> (ø)
NetworkPkg 0.00% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UnitTestFrameworkPkg ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 14 '24 23:03 codecov-commenter