msix-packaging icon indicating copy to clipboard operation
msix-packaging copied to clipboard

Bring changes from office over

Open ryknuth opened this issue 9 months ago • 0 comments

This brings over changes Office needs to build so we can more easily migrate changes in the future.

  1. Comment out a bunch of unreferenced parameters.
  2. Explicitly cast in comparisons
  3. A few optimizations
  4. Some SAL annotations
  5. Remove typedef from enums. Specify default storage type for enums.
  6. Remove problmatic unused ZipObject and ZipObjectWriter ctors
  7. Remove u8 from char* definitions. This is incompatible with C++20 which would need to us char8_t*
  8. Use localtime_s over localtime. This ctor doesn't set m_localTime so I'm not sure if this even matters.
  9. Use LONG instead of long. These have different types on cross platforms

ryknuth avatar Apr 28 '25 18:04 ryknuth