monaco-editor icon indicating copy to clipboard operation
monaco-editor copied to clipboard
verified publisher icon microsoft

Adding more `f-string` features

Open samstrohkorbatt opened this issue 11 months ago • 6 comments

Fixed issue #4601 and add more f-string features with tests:

  1. Walrus operator
  2. Nested f-strings
  3. Lambda functions
  4. {{ }}
  5. Nested strings

samstrohkorbatt avatar Feb 10 '25 20:02 samstrohkorbatt

@rzhao271, Can you review and approve this PR? This fixes the #4601 bug.

samstrohkorbatt avatar Feb 21 '25 20:02 samstrohkorbatt

@hediet Would love to see this issue resolved.

ffiarpg avatar Apr 25 '25 02:04 ffiarpg

@rzhao271

Raymond can you please reach out internally to find someone to approve this?

ffiarpg avatar May 06 '25 08:05 ffiarpg

Looking forward to this fix!

khameeteman avatar May 16 '25 08:05 khameeteman

Would love to see this PR merged!

rdejongeviktor avatar May 16 '25 08:05 rdejongeviktor

Hi everyone thanks for the comments. I left some questions regarding the PR which I'd like to enquire on before merging the PR. If there is no response, I may close the PR in the future to clean the PR stack.

aiday-mar avatar Jun 05 '25 10:06 aiday-mar

Hi,

We at a lot of request for this feature at windmill.dev since we use a monaco-based editor. We have some amount of expertise in Monaco and are happy to give a hand at review or improvement. Is it needed or helpful at all?

rubenfiszel avatar Jun 28 '25 15:06 rubenfiszel

Hi @rubenfiszel thanks for suggesting. As I am not the direct owner of this area, I asked several questions regarding the PR. I would find it helpful if you or the author responds to them.

aiday-mar avatar Jun 30 '25 11:06 aiday-mar

Would be great to see this fix come to fruition, or someone else take up the task. Been experiencing this issue for some time.

SpencerPresley avatar Jul 26 '25 09:07 SpencerPresley

Any updates on this?

landa avatar Aug 06 '25 05:08 landa

Hi as mentioned, I have asked questions on the PR and am awaiting the responses.

aiday-mar avatar Aug 18 '25 09:08 aiday-mar

@samstrohkorbatt Any chance we could convince you to come back to this? Seems like you are very close to the final solution. If you are finding time too tight, would it be alright for another member to take over the pr?

MKaiserW avatar Aug 22 '25 14:08 MKaiserW