microsoft
[Bug][a11y] Accessibility help dialog is not displayed when alt + f1 is pressed > v0.40.0
Reproducible in vscode.dev or in VS Code Desktop?
- [X] Not reproducible in vscode.dev or VS Code Desktop
Reproducible in the monaco editor playground?
- [ ] Not reproducible in the monaco editor playground
Monaco Editor Playground Link
Recent versions of the Monaco editor do not display the accessibility help dialog when alt + f1 is pressed. The editor still announces the availability of the dialog when the text area of the editor is focused by a screen reader user. The help dialog is important for surfacing accessibility help. A new version of the dialog is displayed when using vscode desktop or OSS / web.
Playground Link:
https://microsoft.github.io/monaco-editor/playground.html?source=v0.40.0#example-creating-the-editor-hello-world
Monaco Editor Playground Code
https://microsoft.github.io/monaco-editor/playground.html?source=v0.40.0#example-creating-the-editor-hello-world
Reproduction Steps
- Open the monaco demo page for v0.40 and above
- Focus the editor and press alt + f1
- Observe that nothing happens
Actual (Problematic) Behavior
No accessibility help dialog is displayed
Expected Behavior
The accessibility help dialog is displayed
Additional Context
No response
It looks like this is first introduced in v0.40.0-dev.20230609 https://microsoft.github.io/monaco-editor/playground.html?source=v0.40.0-dev.20230609#example-creating-the-editor-hello-world
@isidorn do you know why the behavior here would be different in the monaco editor playground?
Inspecting the runtime code with the debugger, it looks like editor.action.showAccessibilityHelp is a registered command in v0.39 but in v0.40 it is not.
Thanks for debugging. That explains it. The command is called editor.action.accessibilityHelp now.
@jjaeggli thanks for filling this issue and for finding the culprit it seems. Assigning to @hediet and @meganrogge
@hediet is there a way to bring this fix to v0.39.0? IE updating the command name
