lisa icon indicating copy to clipboard operation
lisa copied to clipboard

Add CVM v6 SKUs

Open kamalca opened this issue 1 year ago • 3 comments

CVM v6 SKUs need to be added to the list of CVM supporting SKUs.

kamalca avatar Oct 14 '24 21:10 kamalca

@squirrelsc @LiliDeng I don't like this method of hard coding SKU families. I don't understand the original justification for it. Is there a better solution?

kamalca avatar Oct 14 '24 21:10 kamalca

I see this commit https://github.com/microsoft/lisa/commit/313cefd01a18cfa295190cd6a1ee4fa4661a3106 is where the check for CVM SKU families is added, but #2370 provides no justification for why we need to check this. We should trust the capability tagging on the SKUs and we should avoid creating more work for ourselves needing to manually update SKU family lists.

kamalca avatar Oct 14 '24 21:10 kamalca

I see this commit 313cefd is where the check for CVM SKU families is added, but #2370 provides no justification for why we need to check this. We should trust the capability tagging on the SKUs and we should avoid creating more work for ourselves needing to manually update SKU family lists.

Do you know the Capabilities names for CVM and Stateless? if yes, we can update coed to reply on them.

LiliDeng avatar Oct 15 '24 04:10 LiliDeng

@LiliDeng LGTM

squirrelsc avatar Oct 22 '24 03:10 squirrelsc

@kamalca could you please make sure you have tested this change? Thanks.

LiliDeng avatar Oct 22 '24 03:10 LiliDeng

@kamalca could you please make sure you have tested this change? Thanks.

I tested SNP and TDX deployment. I am currently running all of my CVM v6 validation with this change and have seen no issues.

kamalca avatar Oct 23 '24 17:10 kamalca