lisa icon indicating copy to clipboard operation
lisa copied to clipboard

Add device passthrough support for libvirt/hyperv platforms

Open smit-gardhariya opened this issue 1 year ago • 2 comments

Add device passthrough support for libvirt/hyperv platform. Create device pool based on given vendor/device ID list. Platform will get device from pool when needed while creating node and put it back into pool when node is getting deleted.

There are changes in LISA tools like lspci to provide information like domain and list of devices for given vendor-device id, hyperv tool to have support to perform start/stop/restart/enable-passthrough for a given vm

smit-gardhariya avatar Aug 13 '24 07:08 smit-gardhariya

@cwize1 please help reviewing for libvirts changes. Thanks.

squirrelsc avatar Aug 13 '24 20:08 squirrelsc

Please change the commits order. Put https://github.com/microsoft/lisa/pull/3379/commits/cd6363b01191bd98c70cb408377eb5b4a6a1afee before https://github.com/microsoft/lisa/pull/3379/commits/19f6308ae81c33f7a1f059278e9664e7da6aef67.

https://github.com/microsoft/lisa/pull/3379/commits/19f6308ae81c33f7a1f059278e9664e7da6aef67 imports classes that are defined in https://github.com/microsoft/lisa/pull/3379/commits/cd6363b01191bd98c70cb408377eb5b4a6a1afee

pupacha avatar Aug 20 '24 10:08 pupacha

Please add example runbook in the PR and commit descriptions.

Added. Please check latest push

smit-gardhariya avatar Aug 30 '24 09:08 smit-gardhariya

@LiliDeng LGTM

squirrelsc avatar Aug 30 '24 20:08 squirrelsc

@smit-gardhariya I ran tier2 cases, saw regression issues on below cases.

verify_nvme_rescind
verify_nvme_sriov_rescind
verify_sriov_disable_enable_pci
verify_gpu_rescind_validation
verify_sriov_ethtool_offload_setting

LiliDeng avatar Sep 03 '24 04:09 LiliDeng

@smit-gardhariya I ran tier2 cases, saw regression issues on below cases.

verify_nvme_rescind
verify_nvme_sriov_rescind
verify_sriov_disable_enable_pci
verify_gpu_rescind_validation
verify_sriov_ethtool_offload_setting

Fixed it now @LiliDeng Issue was with slot value under lspci tool.

smit-gardhariya avatar Sep 03 '24 06:09 smit-gardhariya