lisa icon indicating copy to clipboard operation
lisa copied to clipboard

Skip test cases not supported by CVM

Open kamalca opened this issue 1 year ago • 9 comments

kamalca avatar Feb 26 '24 23:02 kamalca

@johnsongeorge-w I would appreciate your input on which test cases should be skipped. I know some features such as AN plan to be supported in the future while others will never be supported on CVM.

kamalca avatar Feb 26 '24 23:02 kamalca

@LiliDeng LGTM

squirrelsc avatar Feb 27 '24 18:02 squirrelsc

@LiliDeng LGTM

testing

LiliDeng avatar Feb 28 '24 16:02 LiliDeng

By default if run gen2+verify_lsvmbus case, its result is skipped.

CVMSuite.verify_lsvmbus: SKIPPED deployment skipped: capability doesn't support requirement: ['security_profile/requirement not supported in capability. requirement: allowed:False,items:[SecurityProfileType.Standard], capability: allowed:True,items:[SecurityProfileType.CVM]']

with this pr, the result is failed. @kamalca is it expected? CVMSuite.verify_lsvmbus: FAILED deployment failed. LisaException: BadRequest: Use of ConfidentialVM setting is not supported for the provided image.

LiliDeng avatar Feb 29 '24 03:02 LiliDeng

By default if run gen2+verify_lsvmbus case, its result is skipped.

CVMSuite.verify_lsvmbus: SKIPPED deployment skipped: capability doesn't support requirement: ['security_profile/requirement not supported in capability. requirement: allowed:False,items:[SecurityProfileType.Standard], capability: allowed:True,items:[SecurityProfileType.CVM]']

with this pr, the result is failed. @kamalca is it expected? CVMSuite.verify_lsvmbus: FAILED deployment failed. LisaException: BadRequest: Use of ConfidentialVM setting is not supported for the provided image.

I did not change CVM enabled requirement used by that test case and I did not edit the requirements for that test case. My PR was the only difference between the runs?

kamalca avatar Feb 29 '24 05:02 kamalca

By default if run gen2+verify_lsvmbus case, its result is skipped. CVMSuite.verify_lsvmbus: SKIPPED deployment skipped: capability doesn't support requirement: ['security_profile/requirement not supported in capability. requirement: allowed:False,items:[SecurityProfileType.Standard], capability: allowed:True,items:[SecurityProfileType.CVM]'] with this pr, the result is failed. @kamalca is it expected? CVMSuite.verify_lsvmbus: FAILED deployment failed. LisaException: BadRequest: Use of ConfidentialVM setting is not supported for the provided image.

I did not change CVM enabled requirement used by that test case and I did not edit the requirements for that test case. My PR was the only difference between the runs?

yes, you can double check.

LiliDeng avatar Feb 29 '24 05:02 LiliDeng

By default if run gen2+verify_lsvmbus case, its result is skipped. CVMSuite.verify_lsvmbus: SKIPPED deployment skipped: capability doesn't support requirement: ['security_profile/requirement not supported in capability. requirement: allowed:False,items:[SecurityProfileType.Standard], capability: allowed:True,items:[SecurityProfileType.CVM]'] with this pr, the result is failed. @kamalca is it expected? CVMSuite.verify_lsvmbus: FAILED deployment failed. LisaException: BadRequest: Use of ConfidentialVM setting is not supported for the provided image.

I did not change CVM enabled requirement used by that test case and I did not edit the requirements for that test case. My PR was the only difference between the runs?

my bad. your changes look good.

LiliDeng avatar Feb 29 '24 07:02 LiliDeng

@johnsongeorge-w I would appreciate your input on which test cases should be skipped. I know some features such as AN plan to be supported in the future while others will never be supported on CVM.

@johnsongeorge-w could you please share your comments before merging code.

LiliDeng avatar Feb 29 '24 07:02 LiliDeng

@kamalca let know when it is ready for merging.

LiliDeng avatar Mar 01 '24 03:03 LiliDeng