lisa icon indicating copy to clipboard operation
lisa copied to clipboard

BumpDeps: mypy

Open github-actions[bot] opened this issue 3 years ago • 7 comments

Created by Github Action

github-actions[bot] avatar Jan 23 '23 01:01 github-actions[bot]

Brought in the typing changes from the unpinning PR. This should be ready to go.

avylove avatar Jan 24 '23 15:01 avylove

@LiliDeng When you have time, please let Avram know which scenarios should be covered. For the marketplace image, SIG loading tests, it may need to run multiple test cases together, which will load image object from memory.

squirrelsc avatar Jan 24 '23 16:01 squirrelsc

@squirrelsc Rebased again. This basic maintenance PR is now 3 months old. and we're running a version of Mypy that was superseded a year ago.

avylove avatar Apr 26 '23 14:04 avylove

It contains many changes, we don't have bandwidth to test regressions. Please disable related rules, and focus on upgrading mypy version in this PR.

squirrelsc avatar Apr 26 '23 16:04 squirrelsc

That's what I am doing. These are just the changes to make it pass. It keeps growing because it hasn't been merged in so long and bad code keep getting implemented. This is why you have to keep up with dependencies.

avylove avatar Apr 26 '23 16:04 avylove

Please split changes into separated PRs, and provide tested scenarios. We can evaluate the test coverage and remaining risks.

squirrelsc avatar Apr 26 '23 16:04 squirrelsc

What is there to split? These are the changes need to work with the new version. This is a relatively simple PR for anyone with intermediate Python skills to review.

avylove avatar Apr 26 '23 16:04 avylove