helm-web-api icon indicating copy to clipboard operation
helm-web-api copied to clipboard
verified publisher icon microsoft

Custom values not working

Open jldinh opened this issue 5 years ago • 0 comments

Custom values provided are ignored, because the check on whether values are set is inverted. https://github.com/microsoft/helm-web-api/blob/b8d945249943db07a6bd51c638c2281e5282d082/on-demand-micro-services-deployment-k8s/helm.js#L116 I think the this keyword should be omitted, because it is in a static method and I am not sure what it refers to here.

A follow up issue is that the sample code uses a url-encoded form to send the POST data, and the body parser does not seem to work well as it is. Using JSON encoding in the POST solves the issue.

jldinh avatar Jun 03 '20 11:06 jldinh