fluentui
fluentui copied to clipboard
fix(react-list): Do not crash during roles/elements validation
Previous Behavior
Previously, when element validation in List failed, an error would be thrown. This would crash the app if the user switches from navigation mode items to composite and overall is not a great experience.
New Behavior
This PR wraps the validation in try/catch block and just console.errors the output instead, handling the errors gracefully.
Related Issue(s)
- Fixes #34467
📊 Bundle size report
| Package & Exports | Baseline (minified/GZIP) | PR | Change |
|---|---|---|---|
| react-components react-components: entire library |
1.273 MB320.869 kB |
1.274 MB320.917 kB |
150 B 48 B |
| react-list List |
88.742 kB26.341 kB |
88.892 kB26.38 kB |
150 B 39 B |
| react-list ListItem |
112.167 kB33.161 kB |
112.208 kB33.17 kB |
41 B 9 B |
Unchanged fixtures
| Package & Exports | Size (minified/GZIP) |
|---|---|
| react-components react-components: Button, FluentProvider & webLightTheme |
68.79 kB19.902 kB |
| react-components react-components: Accordion, Button, FluentProvider, Image, Menu, Popover |
235.687 kB68.205 kB |
| react-components react-components: FluentProvider & webLightTheme |
43.624 kB14.255 kB |
| react-portal-compat PortalCompatProvider |
8.386 kB2.624 kB |
| react-timepicker-compat TimePicker |
109.052 kB36.053 kB |
Pull request demo site: URL
