fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

ColorPicker

Open gouttierre opened this issue 1 year ago • 6 comments

💡 When you create a PR for any of the checklist items, add a link to this Epic under the PR's Related Issues section.

Preparation

Implementation

Validation

gouttierre avatar Jun 20 '24 12:06 gouttierre

📢

  • Partners are asking about the ColorPicker v9 and are not interested in the ColorCompact variant.
  • Whiteboard, Office AI is using color picker v8 with swatch picker v9 + are willing to contribute.
  • ODSP, Viva are also interested in the ETA of the component.
  • Need design resources + PoC and Prague eng. allocation.

cc @tudorpopams , @JustSlone , @paulgildea, @jurokapsiar

gouttierre avatar Jun 20 '24 13:06 gouttierre

📢

  • On hold until a severity issue gets addressed by dev.
  • Valentyna will be the dev assigned and Toshie will be on the design PoC.

cc @tudorpopams , @ValentinaKozlova , @jurokapsiar , @JustSlone

gouttierre avatar Jul 01 '24 12:07 gouttierre

Designer is also interested in a v9 based ColorPicker

paulgildea avatar Jul 01 '24 15:07 paulgildea

📢

  • Valentyna has almost completed research on the use cases and confirmed with our partners: Anuj / Amit at WXP, and Bakhodir at ODSP on their needs.
  • Each partner is interested in the default v8 functionality. However, Valentyna has gathered implementation details to enhance the component further and plans to incorporate these insights into her implementation strategy to scale the component in the future.
  • Valentyna will begin collaborating with Toshie on the design specifications for the behaviors.

cc @ValentinaKozlova , @tudorpopams , @JustSlone , @paulgildea , @jurokapsiar

gouttierre avatar Jul 31 '24 13:07 gouttierre

📢

  • ColorSlider is merged. AlphaSlider is in review, ColorArea in draft PR mode.
  • Currently, the engineer is working on adding context to the ColorPicker.

cc~ @tudorpopams , @ValentinaKozlova , @paulgildea , @JustSlone

gouttierre avatar Sep 04 '24 12:09 gouttierre

📢

  • ColorArea mouse events - in review.
  • Dev is working on ColorPicker combined along with ColorArea keyboard events.

cc @tudorpopams , @ValentinaKozlova

gouttierre avatar Oct 16 '24 12:10 gouttierre

📢

cc ~ @ValentinaKozlova , @tudorpopams , @JustSlone

gouttierre avatar Dec 05 '24 13:12 gouttierre

I cannot seem to install the preview package & all stackblitzes seem to fail.

Cannot find module '@fluentui/react-color-picker-preview' or its corresponding type declarations.ts(2307)

Looking at npm, it seems the package is empty. Am I missing something or is the package not fully available yet?

emil-eklund avatar Dec 06 '24 07:12 emil-eklund

I cannot seem to install the preview package & all stackblitzes seem to fail.

Cannot find module '@fluentui/react-color-picker-preview' or its corresponding type declarations.ts(2307)

Looking at npm, it seems the package is empty. Am I missing something or is the package not fully available yet?

Hello @emil-eklund, thank you for catching that. I'll investigate why it's not fully available

ValentinaKozlova avatar Dec 06 '24 11:12 ValentinaKozlova

Hey @emil-eklund, now ColorPicker is available. https://stackblitz.com/edit/pbynm62n?file=src%2Fexample.tsx There was an issue with version of tinyColor. It got latest and it didn't work.

ValentinaKozlova avatar Dec 09 '24 11:12 ValentinaKozlova

@ValentinaKozlova Thank you! Can confirm it works now!

As an aside, where do you collect feedback from the preview? I noticed the component tends to steal focus when paired with an input textbox but I don't want to disrupt your normal workflow.

Edit: added example from storybook

Image

emil-eklund avatar Dec 09 '24 12:12 emil-eklund

@emil-eklund, Thank you for your feedback. For bug reports, you can create issues on GitHub, and for ideas or feedback, please use GitHub Discussions. Kindly assign them to me. Regarding this specific issue, it has already been addressed: #33415. Thank you once again for looking into and reporting it.

ValentinaKozlova avatar Dec 09 '24 16:12 ValentinaKozlova

Hey @emil-eklund, the bug is fixed. You might want to check it out: https://react.fluentui.dev/?path=/docs/preview-components-colorpicker--docs

ValentinaKozlova avatar Dec 12 '24 13:12 ValentinaKozlova

Thank you, @ValentinaKozlova! It works beautifully in the demo now! 🥳 Haven't been able to try it out in our system yet as the npm package is a bit old. (latest published 3 days ago, your commit was yesterday and the nightly build is empty).

emil-eklund avatar Dec 12 '24 15:12 emil-eklund

📢

gouttierre avatar Jan 07 '25 12:01 gouttierre