fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

add: tree-item and tree-view component

Open imink opened this issue 1 year ago • 5 comments

Previous Behavior

New Behavior

This is the PR to create TreeView and TreeItem Component to @microsoft/fluentui/web-components

Related Issue(s)

  • Fixes #

imink avatar Jun 05 '24 07:06 imink

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Jun 05 '24 07:06 codesandbox-ci[bot]

Can we add a tree-view story as well! And let's rerun the codesandbox pipeline too. According to Chris, you can do:

you can try /azp run - it also could be that the PR needs to be up to date. I'd start w/ azp and then update the PR if it fails again to see if that's the root cause.

mohamedmansour avatar Jun 07 '24 20:06 mohamedmansour

Can we add a tree-view story as well! And let's rerun the codesandbox pipeline too. According to Chris, you can do:

you can try /azp run - it also could be that the PR needs to be up to date. I'd start w/ azp and then update the PR if it fails again to see if that's the root cause.

updated. @mohamedmansour

imink avatar Jul 23 '24 05:07 imink

@davatron5000 is this PR looking good or needs more work? Please be critical :) To make sure we build the best components!

mohamedmansour avatar Aug 12 '24 15:08 mohamedmansour

@mohamedmansour There's a handful of unresolved conversations. Happy to provide more clarity there if necessary and do a full re-review once that feedback has been addressed.

davatron5000 avatar Aug 12 '24 15:08 davatron5000

📊 Bundle size report

✅ No changes found

github-actions[bot] avatar Dec 04 '24 09:12 github-actions[bot]

Pull request demo site: URL

github-actions[bot] avatar Dec 04 '24 09:12 github-actions[bot]

@mohamedmansour @davatron5000 @chrisdholt Please take a look. I've resolved most of the comments.

imink avatar Dec 05 '24 09:12 imink

The other thing I noticed was, it seems I can currently select multiple items, e.g. if I select a parent item, then a child item, both parent and child items are in selected state. Not sure if this is intended behavior or not. I didn't find a clear answer from Figma. image

marchbox avatar Dec 09 '24 21:12 marchbox

The other thing I noticed was, it seems I can currently select multiple items, e.g. if I select a parent item, then a child item, both parent and child items are in selected state. Not sure if this is intended behavior or not. I didn't find a clear answer from Figma. image

This is a bug, selected style should be cleared once it's not selected.

imink avatar Dec 10 '24 10:12 imink

Thank you for your PR. Closing because Tree and TreeItem are now in Fluent WCv3. Your contribution made a big difference in getting these components out the door. Sorry our feedback loops got out of sync and the review process dragged on.

Resolved by #33973.

davatron5000 avatar May 06 '25 15:05 davatron5000