add: tree-item and tree-view component
Previous Behavior
New Behavior
This is the PR to create TreeView and TreeItem Component to @microsoft/fluentui/web-components
Related Issue(s)
- Fixes #
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Can we add a tree-view story as well! And let's rerun the codesandbox pipeline too. According to Chris, you can do:
you can try /azp run - it also could be that the PR needs to be up to date. I'd start w/ azp and then update the PR if it fails again to see if that's the root cause.
Can we add a tree-view story as well! And let's rerun the codesandbox pipeline too. According to Chris, you can do:
you can try /azp run - it also could be that the PR needs to be up to date. I'd start w/ azp and then update the PR if it fails again to see if that's the root cause.
updated. @mohamedmansour
@davatron5000 is this PR looking good or needs more work? Please be critical :) To make sure we build the best components!
@mohamedmansour There's a handful of unresolved conversations. Happy to provide more clarity there if necessary and do a full re-review once that feedback has been addressed.
📊 Bundle size report
✅ No changes found
Pull request demo site: URL
@mohamedmansour @davatron5000 @chrisdholt Please take a look. I've resolved most of the comments.
The other thing I noticed was, it seems I can currently select multiple items, e.g. if I select a parent item, then a child item, both parent and child items are in selected state. Not sure if this is intended behavior or not. I didn't find a clear answer from Figma.
The other thing I noticed was, it seems I can currently select multiple items, e.g. if I select a parent item, then a child item, both parent and child items are in selected state. Not sure if this is intended behavior or not. I didn't find a clear answer from Figma.
This is a bug, selected style should be cleared once it's not selected.
Thank you for your PR. Closing because Tree and TreeItem are now in Fluent WCv3. Your contribution made a big difference in getting these components out the door. Sorry our feedback loops got out of sync and the review process dragged on.
Resolved by #33973.
