fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

[Bug]: make-styles-overrides-win conformance test doesn't respect the `wrapper` renderOption

Open CampbellOwen opened this issue 1 year ago • 0 comments

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: macOS 14.4.1
    CPU: (14) arm64 Apple M3 Max
    Memory: 66.67 MB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 123.0.6312.107
    Edge: 124.0.2478.80
    Safari: 17.4.1

Are you reporting Accessibility issue?

None

Reproduction

https://github.com/CampbellOwen/fluentui/blob/user/owcampbe/TestIssueRepro/packages/react-components/react-button/src/components/Button/Button.test.tsx

I added a Wrapper to Button.test.tsx in react-button that doesn't render the button component and the make-styles-overrides-win still passes.

Bug Description

Actual Behavior

The make-styles-overrides-win conformance test in react-conformance-griffel directly renders the Component given and ignores the renderOptions: { wrapper: _ } option.

Expected Behavior

The call to ReactDOM.render(element, container); should pass the wrapper option if provided. This would allow components that require an external context to be tested.

Logs

No response

Requested priority

Normal

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] The provided reproduction is a minimal reproducible example of the bug.

CampbellOwen avatar May 08 '24 00:05 CampbellOwen